[OFBIZ-9303] Remove hard-coded success/error message variables set in service output

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: ALL COMPONENTS
• Assignee: Deepak Dixit
• Reporter: Devanshu Vyas
• Created: 05/Apr/17 06:18
• Updated: 01/Sep/20 09:34
• Resolved: 16/May/17 17:04

Description

I found that certain services in OFBiz set error/success message values in o hard-codedly like:

result.put("errorMessage", errMsg);
result.put("successMessage", message);

I think it shouldn't be set like this, as we have constants in ModelService class for this purpose. ModelService.ERROR_MESSAGE/ModelService.SUCCESS_MESSAGE should be used to set the error and success messages, for in case we want to change the constant's value, no services will be affected.

result.put(ModelService.ERROR_MESSAGE, errMsg);
result.put(ModelService.SUCCESS_MESSAGE, errMsg);