Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9261

Handle only labels with the "_" separator between languages and countries

    Details

      Description

      I explained that in the second message in this dev ML thread https://s.apache.org/S3Ao

      This is handled in LabelManagerFactory.java

                                  Element valueElem = (Element) valueNode;
                                  // Support old way of specifying xml:lang value.
                                  // Old way: en_AU, new way: en-AU
                                  String localeName = valueElem.getAttribute("xml:lang");
                                  if( localeName.contains("_")) {
                                      localeName = localeName.replace('_', '-');
                                  }
      

      I'll replace this snippet by throwing an exception in order to now to automatically detect issues

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Moreover I notices that there are no longer reasons to bypass the ExampleEntityLabels and ProductPromoUiLabels files. This is a bug and I removed it.

        Fixed in
        trunk r1787047
        R16.11 r1787048
        I did not backport in older branches, conflicts and not really needed.

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Moreover I notices that there are no longer reasons to bypass the ExampleEntityLabels and ProductPromoUiLabels files. This is a bug and I removed it. Fixed in trunk r1787047 R16.11 r1787048 I did not backport in older branches, conflicts and not really needed.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Fixed and done

        Show
        jacques.le.roux Jacques Le Roux added a comment - Fixed and done

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development