OK I was ready to close this issue with this message
trunk r1784549 + r1784555 + r1784558
R16.11 r1784550 + r1784559
R15.11 & 14.11 r1784556+ r1784560
I even wrote that
It was an easy fix, I just imported
<SystemProperty systemPropertyId="port.https" systemResourceId="url" systemPropertyValue=""/>
in trunk demo and all work perfectly.
But I missed one point: how deep the ecommerce webapp is entrenched in some applications components. This can at least be tested with product and catalog webapp.
- Get to https://demo-stable.ofbiz.apache.org/catalog/control/EditProduct?productId=GZ-1000
- Click on the "Product Page" button (you may notice an error which has been "fixed", more a workaround, at
- Click on the logout link you get to https://demo-stable.ofbiz.apache.org/ecommerce/control/main but also to blank page, you just got a 404. The same happens locally, it's not related to demos, the letsencrypt certificate or the HTTPD frontend config.
If you replace ecommerce/control/main by ecomseo in the URL, it works again. IIRW this was the initial reason I switched the trunk demo link from the site home page to ecomseo.
Also if you replace ecommerce by ecomseo in CatalogMenus.xml then all works really perfectly. What I could do is to make this a parameter, but if you look for "ecommerce" in applications you find 96 harcoded "ecommerce" strings. Among the 96 harcoded "ecommerce" strings I could replace those that have a relation with URLs generation by "ecomseo" and that would be it.
But at this stage I think we need to think more about it. I see 3 alternatives:
- Fixes the underlying problems with ecommerce, good luck while shaving the yak! See
OFBIZ-9234 and OFBIZ-9235 I already crossed while working on the current issue, for instance.
- My proposition above to replace "ecommerce" strings by "ecomseo". But I know some are reluctants about that because the ecomseo specifications have not been defined. Though we also have no specifications for ecommerce, I can understand this concern. It would be good to have ecomseo specifications defined before definitely switching to it. I thought about reverting and keep up later. But I fear it's a risk of loosing momentum and have to do it again if other changes stack on. I'll rather retroengineer ecomseo to explain what really changes. If I can't explain all at a functional level, I'll ask Jinghai and especially Jonathan Schikowski, anyway I already planned to do so.
- This is only related to the logout when coming from catalog/product, and a simpler way is to remove all ecommerce links from applications. We anyway want to remove dependencies from plugins in applications. And I believe it's where we should start.
I'm inclided to the 3rd option, I'll create a thread on dev ML to discuss about the 3 points above.
In the meantime, I'll now restart the demos and change the link from the site home page, for at least test and let test.