[OFBIZ-9185] The deleteWorkEffort service is incomplete and even wrong

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: Trunk, Upcoming Branch
• Component/s: workeffort
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 22/Jan/17 12:57
• Updated: 11/Jan/22 08:48

Description

This issue is very old (pre Apache) so all versions are affected (I just tested with R09.04)

When you try to delete a Workeffort which has an established relationship with a RuntimeData or any of the entities Workeffort has a relation with (eg NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one fails

Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, would be to add

<remove-related value-field="lookedUpValue" relation-name="CustRequestWorkEffort"/>

Besides (minor) ApplicationSandbox is maybe missing in the implementation of deleteWorkEffort.
There is indeed a workeffortId in ApplicationSandbox.
So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
But it can anyway be deleted by a simple delete-by-and (or alike), so not a problem for deleteWorkEffort, though this case could be handled there also.

Summary: the deleteWorkEffort service needs more work. The only solution I see is to remove the FK from the Workeffort (ie put null in the related field if it's not) and then deleted the related entity instead of directly calling remove-related

Issue Links

• is related to: OFBIZ-9568 The deleteProductionRunRoutingTask service is used but not implemented
• is related to: OFBIZ-9648 Deleting workeffort from Find WorkEffort page gives unusual response