[OFBIZ-9157] "View Order" throws exception in getReturnableQuantity

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 15.12, Release Branch 16.11
• Fix Version/s: Release Branch 14.12, Release Branch 15.12, 16.11.02, 17.12.01
• Component/s: order

Environment

Encountered this in 15.x and 16.x Trunk versions

• Flags: Patch
• Assignee: Jacques Le Roux
• Reporter: Leonard Lin
• Created: 27/Dec/16 14:43
• Updated: 21/Jan/17 11:41
• Resolved: 21/Jan/17 11:18

Description

Steps to Reproduce:

• Create a sales order
• Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
• set the status of the order to completed
• go to order-management and try to open the order for display like:
  https://localhost:8443/ordermgr/control/orderview?orderId=XXXXX

Expected:

• the order is displayed with status completed

Actual:

• A groovy exception is displayed.

Analysis:
The service "getReturnableQuantity" throws an exception because it returns the returnablePrice = null, because the unitPrice of the orderItem was null.
The OUT field returnablePrice is mandatory according to the service-definition. The return parameter is set but the value is null, hence the exception.

Attached is a patch that will adjust the service-deinition to allow for "null" value of the OUT parameter.