Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9152

SimpleMethod: FindByAnd never using EntityListIterator

    Details

      Description

      Since the introduction of EntityQuery there was no distinction between a simple method tags <find-by-and use-iterator="true"> and <find-by-and use-iterator="false"> (except cache handling).

      There is a condition "if (useIterator)" but with entityQueries did use "[...].queryList()".

        Issue Links

          Activity

          Hide
          vogelsme Mirko Vogelsmeier added a comment - - edited

          Changed the method call to the correct one. (To be honest I did not run tests afterwards as gradle doesnt work with my ofbiz currently - I would be glad if someone else could do that)

          Show
          vogelsme Mirko Vogelsmeier added a comment - - edited Changed the method call to the correct one. (To be honest I did not run tests afterwards as gradle doesnt work with my ofbiz currently - I would be glad if someone else could do that)
          Hide
          gareth.carter Gareth Carter added a comment -

          This was changed in commit 1646212. I can't see any problem changing as you suggested.

          Show
          gareth.carter Gareth Carter added a comment - This was changed in commit 1646212. I can't see any problem changing as you suggested.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Thanks Mirko for the "patch" (easy anyway) and Gareth for the confirmation.

          FIxed in
          trunk r1782498
          R16.11 r1782499
          R15.12 r1782525

          It's maybe possible to backport more by hand, but I did not.

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Mirko for the "patch" (easy anyway) and Gareth for the confirmation. FIxed in trunk r1782498 R16.11 r1782499 R15.12 r1782525 It's maybe possible to backport more by hand, but I did not.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              vogelsme Mirko Vogelsmeier
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development