Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9111

Service "deletePayHistory" does not have correct implementation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: humanres
    • Labels:
      None

      Description

      Service "deletePayHistory" does not have correct implementation.This service set thru_date then remove record of PayHistory.This should be corrected.

      1. OFBIZ-9111.patch
        2 kB
        Pawan Verma
      2. OFBIZ-9111.patch
        0.7 kB
        Pawan Verma

        Activity

        Hide
        pawan.verma Pawan Verma added a comment -

        Attaching patch for this bug. This patch will maintain thru date of PayHistory.

        Show
        pawan.verma Pawan Verma added a comment - Attaching patch for this bug. This patch will maintain thru date of PayHistory.
        Hide
        mbrohl Michael Brohl added a comment -

        Pawan Verma,

        thanks for your contribution. Derived from the naming "deletePayHistory" I would say that the remove-value is correct, it deletes the data entry. Maybe it's a bit misleading that the thruDate is first set and stored before the value is removed so maybe we should remove the lines

        <set field="lookedUpValue.thruDate" from-field="nowTimeStamp"/>
        <store-value value-field="lookedUpValue"/>

        Show
        mbrohl Michael Brohl added a comment - Pawan Verma , thanks for your contribution. Derived from the naming "deletePayHistory" I would say that the remove-value is correct, it deletes the data entry. Maybe it's a bit misleading that the thruDate is first set and stored before the value is removed so maybe we should remove the lines <set field="lookedUpValue.thruDate" from-field="nowTimeStamp"/> <store-value value-field="lookedUpValue"/>
        Hide
        pawan.verma Pawan Verma added a comment -

        Hello Michael Brohl,

        I totally agree with you. In that case, we can switch this service implementation from simple to entity-auto. I am attaching updated patch please have a look.

        Show
        pawan.verma Pawan Verma added a comment - Hello Michael Brohl , I totally agree with you. In that case, we can switch this service implementation from simple to entity-auto. I am attaching updated patch please have a look.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        I think instead of delete it should call expirePayHistory.

        Show
        deepak.dixit Deepak Dixit added a comment - I think instead of delete it should call expirePayHistory.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        This has been done at ofbiz framework at r#1801348
        Thanks Pawan Vemra for your contribution.

        Show
        deepak.dixit Deepak Dixit added a comment - This has been done at ofbiz framework at r#1801348 Thanks Pawan Vemra for your contribution.

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            pawan.verma Pawan Verma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development