[OFBIZ-904] Error when "Inventory Facility Id" is left blank in product store settings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 14.12.01, 12.04.06, 13.07.02
• Component/s: ecommerce, product

Environment

OFBiz Rev. 529997 on Windows XP.

• Assignee: Ashish Vijaywargiya
• Reporter: Michel Dielissen
• Created: 19/Apr/07 10:01
• Updated: 15/Nov/14 21:23
• Resolved: 15/Nov/14 07:08

Description

When creating a new store and the "Inventory Facility Id" field is left blank (with the store settings) then the productlist (Browse categories in the e-commerce store) gives an error and is not rendered.

Error:
2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [ ModelScreen.java:148:ERROR] Error rendering screen component://ecommerce/widget/CatalogScreens.xml#productsummary: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh], line [65]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm. : at Line: 65 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh : if ( product != null ) {
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm.) (Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh], line [65]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm. : at Line: 65 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh : if ( product != null ) {
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm.)). Rolling back transaction.

Think it has something todo with:
file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [ ServiceDispatcher.java:459:DEBUG] Sync service [ecommerce/getInventoryAvailableByFacility]

So maybe the "Inventory Facility Id" field has to be a required field? Or maybe better to run the "getInventoryAvailableByFacility" only when an Inventory Facility is filled with the store settings?

Comment Jacopo: this should be improved; for example the facility in the store should be mandatory if the requireInventory flag is set.