Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7828 Entity and Service definition
  3. OFBIZ-8843

Improvements in CommEventContentAssoc entity definition and services

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: content
    • Labels:
      None

      Description

      Required improvements;

      • All is good with entity definition .
      • Add crud services using entity-auto (services_commevent.xml). Also remove the existing services from ContentServices.xml.
      • Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented.
      • As existing workflows are implemented to delete the records so use the delete action for the same.
      • Need to convert Update and Delete services. Create can not be converted due to some conditional code. Keep the existing services names as is.
      1. OFBIZ-8843.patch
        4 kB
        Rishi Solanki
      2. OFBIZ-8843_plugins.patch
        1 kB
        Devanshu Vyas
      3. OFBIZ-8843.patch
        2 kB
        Devanshu Vyas
      4. OFBIZ-8843.patch
        2 kB
        Devanshu Vyas

        Activity

        Hide
        arunpati Arun Patidar added a comment -

        Improved patches has been committed at rev: 1802771 and 1802772

        Thanks Devanshu for your contribution.

        Show
        arunpati Arun Patidar added a comment - Improved patches has been committed at rev: 1802771 and 1802772 Thanks Devanshu for your contribution.
        Hide
        devanshu.vyas Devanshu Vyas added a comment -

        invoke="expire" was missed, so added updated patch for it.

        Show
        devanshu.vyas Devanshu Vyas added a comment - invoke="expire" was missed, so added updated patch for it.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Thank you Devanshu, what Deepak make us to notice is we should call the invoke="expire" instead of invoke="delete". Please change this and I think all should be okay. Thanks again for your effort and help.

        Show
        rishisolankii Rishi Solanki added a comment - Thank you Devanshu, what Deepak make us to notice is we should call the invoke="expire" instead of invoke="delete". Please change this and I think all should be okay. Thanks again for your effort and help.
        Hide
        devanshu.vyas Devanshu Vyas added a comment -

        Corrected the service name as per the suggestion and updated all references found. Attaching files for the same.

        Show
        devanshu.vyas Devanshu Vyas added a comment - Corrected the service name as per the suggestion and updated all references found. Attaching files for the same.
        Hide
        rishisolankii Rishi Solanki added a comment - - edited

        Deepak thanks for review and Devanshu for updated patch.

        Show
        rishisolankii Rishi Solanki added a comment - - edited Deepak thanks for review and Devanshu for updated patch.
        Hide
        devanshu.vyas Devanshu Vyas added a comment -

        I have deleted the patch I uploaded a few minutes back. I will create a new patch and upload it soon.
        Sorry, the confusion.

        Show
        devanshu.vyas Devanshu Vyas added a comment - I have deleted the patch I uploaded a few minutes back. I will create a new patch and upload it soon. Sorry, the confusion.
        Hide
        devanshu.vyas Devanshu Vyas added a comment -

        Renamed the service name and description to use expire instead of remove.

        Show
        devanshu.vyas Devanshu Vyas added a comment - Renamed the service name and description to use expire instead of remove.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        I think we have to use expire instead of deleting communication event assoc.

        Show
        deepak.dixit Deepak Dixit added a comment - I think we have to use expire instead of deleting communication event assoc.
        Hide
        arunpati Arun Patidar added a comment -

        Committed revision 1802656

        Thanks Rishi Solanki for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed revision 1802656 Thanks Rishi Solanki for your contribution.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Here is the patch for the same with some modification from the details shared in the ticket description.

        • Did not convert the create operation as create service handling some scenarios and conditionally set the now time stamp in from date field.
        • In update service match the input parameters to match the existing allowed fields to update.
        Show
        rishisolankii Rishi Solanki added a comment - Here is the patch for the same with some modification from the details shared in the ticket description. Did not convert the create operation as create service handling some scenarios and conditionally set the now time stamp in from date field. In update service match the input parameters to match the existing allowed fields to update.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development