Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7520 Minilang code readability and consistency improvements
  3. OFBIZ-8447

OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 16.11.01
    • None
    • ALL COMPONENTS
    • None

    Description

      Code written in Minilang for the if-compare tag is not consistent throughout the application. The correct pattern to write is
      <if-compare-field field="finAccountTrans.statusId" operator="not-equals" to-field="parameters.statusId">

      I found various other ways in which this tag is written, like
      <if-compare-field to-field="partyAcctgPreference.baseCurrencyUomId" operator="equals" field="orderHeader.currencyUom" />

      <if-compare-field operator="equals" field="invoiceTotal" to-field="payment.actualCurrencyAmount">

      Attachments

        1. OFBIZ-8447.patch
          20 kB
          Devanshu Vyas
        2. OFBIZ-8447.patch
          35 kB
          Abhijeet Ashapure

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            devanshu Devanshu Vyas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment