Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7520 Minilang code readability and consistency improvements
  3. OFBIZ-8447

OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 16.11.01
    • Fix Version/s: None
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      Code written in Minilang for the if-compare tag is not consistent throughout the application. The correct pattern to write is
      <if-compare-field field="finAccountTrans.statusId" operator="not-equals" to-field="parameters.statusId">

      I found various other ways in which this tag is written, like
      <if-compare-field to-field="partyAcctgPreference.baseCurrencyUomId" operator="equals" field="orderHeader.currencyUom" />

      <if-compare-field operator="equals" field="invoiceTotal" to-field="payment.actualCurrencyAmount">

        Attachments

        1. OFBIZ-8447.patch
          20 kB
          Devanshu Vyas
        2. OFBIZ-8447.patch
          35 kB
          Abhijeet Ashapure

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              devanshu.vyas Devanshu Vyas
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: