Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8323

can enter empty content for product facility

    Details

    1. OFBIZ-8323.patch
      4 kB
      Lalit Dashora

      Issue Links

        Activity

        Hide
        priya.sharma.9362 Priya Sharma added a comment - - edited

        Hello Wai,

        Actually when you click the add button, facility field contains the first value in the dropdown box and the same is being submitted with the form. So the content is not empty.

        But yes I do see that when the same facility is added again error and success message are seen simultaneously. Perhaps we can look into that issue.

        Regards!

        Show
        priya.sharma.9362 Priya Sharma added a comment - - edited Hello Wai, Actually when you click the add button, facility field contains the first value in the dropdown box and the same is being submitted with the form. So the content is not empty. But yes I do see that when the same facility is added again error and success message are seen simultaneously. Perhaps we can look into that issue. Regards!
        Hide
        lalit.dashora Lalit Dashora added a comment -

        Hello @Wai Priya Sharma

        This is a Generic Issue with EntityAutoEngine in which success message is appended to result after invoking create, update, delete, expire methods. Due to this, the success message is always appended to the result even if the create, update, delete, expire methods are returning error.

        Now Added a conditional check that if the method (create, update, delete, expire) is returning success then only it will append success message to the result.

        Please find the attached patch with the proper fix.

        Tagging Rohit Koushal Deepak Dixit

        Show
        lalit.dashora Lalit Dashora added a comment - Hello @Wai Priya Sharma This is a Generic Issue with EntityAutoEngine in which success message is appended to result after invoking create, update, delete, expire methods. Due to this, the success message is always appended to the result even if the create, update, delete, expire methods are returning error. Now Added a conditional check that if the method (create, update, delete, expire) is returning success then only it will append success message to the result. Please find the attached patch with the proper fix. Tagging Rohit Koushal Deepak Dixit
        Hide
        rishisolankii Rishi Solanki added a comment -

        Lalit Dashora Thanks for your patch, could you please do the following changes and upload the patch again.

        • No need to check the success in create and update.
        • For all create update delete and expire, you can directly return the success message using the ServiceUtil.returnSuccess("Your Message")
        Show
        rishisolankii Rishi Solanki added a comment - Lalit Dashora Thanks for your patch, could you please do the following changes and upload the patch again. No need to check the success in create and update. For all create update delete and expire, you can directly return the success message using the ServiceUtil.returnSuccess("Your Message")
        Hide
        lalit.dashora Lalit Dashora added a comment -

        Thanks Rishi Solanki for valuable input. I have incorporated the changes as suggested by you and updated the patch file.

        Tagging Rohit Koushal Deepak Dixit

        Show
        lalit.dashora Lalit Dashora added a comment - Thanks Rishi Solanki for valuable input. I have incorporated the changes as suggested by you and updated the patch file. Tagging Rohit Koushal Deepak Dixit
        Hide
        rishisolankii Rishi Solanki added a comment -

        Thanks Lalit Dashora Rohit Koushal for your contribution. Your patch has been committed in revision 1807908.

        Tagging Deepak Dixit

        Show
        rishisolankii Rishi Solanki added a comment - Thanks Lalit Dashora Rohit Koushal for your contribution. Your patch has been committed in revision 1807908. Tagging Deepak Dixit
        Hide
        rishisolankii Rishi Solanki added a comment -

        Need to check the releases to port the fixes, so not resolving the issue.

        Show
        rishisolankii Rishi Solanki added a comment - Need to check the releases to port the fixes, so not resolving the issue.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Test integration failed with the current patch, patch with minor modification committed in revision 1808833.

        Show
        rishisolankii Rishi Solanki added a comment - Test integration failed with the current patch, patch with minor modification committed in revision 1808833.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Issue not persist with older branch than 16.11, because instead of invoke methods it contains the inline code for each block and returns proper success, failure and error.

        Show
        rishisolankii Rishi Solanki added a comment - Issue not persist with older branch than 16.11, because instead of invoke methods it contains the inline code for each block and returns proper success, failure and error.

          People

          • Assignee:
            rishisolankii Rishi Solanki
            Reporter:
            wt Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development