Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      Menu-name should be in upper camel case as per best practice. There are few places where menu-names are in lower camel case. Need to fix these to maintain consistency.

        Activity

        Hide
        Tanmay Tanmay Muley added a comment -

        Yes i think we can close it.

        Show
        Tanmay Tanmay Muley added a comment - Yes i think we can close it.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Tanmay, so I think we can close again now, right?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Tanmay, so I think we can close again now, right?
        Hide
        mbrohl Michael Brohl added a comment -

        Re-checked by Tanmay, thanks!

        Show
        mbrohl Michael Brohl added a comment - Re-checked by Tanmay, thanks!
        Hide
        mbrohl Michael Brohl added a comment -

        Tanmay,

        thank you for your feedback and checking the code again.

        Show
        mbrohl Michael Brohl added a comment - Tanmay, thank you for your feedback and checking the code again.
        Hide
        Tanmay Tanmay Muley added a comment -

        Sorry for the inconvenience, I have rechecked the code for errors and I think it is bug free now.
        Thanks for spotting & fixing the mistake.

        Show
        Tanmay Tanmay Muley added a comment - Sorry for the inconvenience, I have rechecked the code for errors and I think it is bug free now. Thanks for spotting & fixing the mistake.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I have not already spotted more issues in the commit and I hope those who worked on it will check, sorry if I was not clear enough.

        Show
        jacques.le.roux Jacques Le Roux added a comment - I have not already spotted more issues in the commit and I hope those who worked on it will check, sorry if I was not clear enough.
        Hide
        mbrohl Michael Brohl added a comment -

        I'm fine with leaving this open if you've already spotted more issues in the commit. I missed to read this fact out of "It's possible that there are more bugs like that (in screenlet, elsewere?) I did not check, I reopen for that, thanks!".

        Show
        mbrohl Michael Brohl added a comment - I'm fine with leaving this open if you've already spotted more issues in the commit. I missed to read this fact out of "It's possible that there are more bugs like that (in screenlet, elsewere?) I did not check, I reopen for that, thanks!".
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        It's our responsibility to fix bugs, I was fixing one when I stumbled upon the one I fixed at r1760325
        and I'm still working on the other .

        My priority at the moment is to fix the other bug not to create a new Jira. Feel free to create one or to close this one again and wait for a proof there were issues in r1760059.

        Show
        jacques.le.roux Jacques Le Roux added a comment - It's our responsibility to fix bugs, I was fixing one when I stumbled upon the one I fixed at r1760325 and I'm still working on the other . My priority at the moment is to fix the other bug not to create a new Jira. Feel free to create one or to close this one again and wait for a proof there were issues in r1760059.
        Hide
        mbrohl Michael Brohl added a comment -

        Jacques, thanks for spotting and fixing this.

        Wouldn't it be better to close this issue again and either reopen or create a new issue if there is another bug instead of leaving it open in case there might be a bug?

        Show
        mbrohl Michael Brohl added a comment - Jacques, thanks for spotting and fixing this. Wouldn't it be better to close this issue again and either reopen or create a new issue if there is another bug instead of leaving it open in case there might be a bug?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        At r1760325 I fixed a bug introduced with one of the subtasks.

        It's possible that there are more bugs like that (in screenlet, elsewere?) I did not check, I reopen for that, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - At r1760325 I fixed a bug introduced with one of the subtasks. It's possible that there are more bugs like that (in screenlet, elsewere?) I did not check, I reopen for that, thanks!
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Tanmay,

        all subtask changes are in trunk r1760059.

        Show
        mbrohl Michael Brohl added a comment - Thanks Tanmay, all subtask changes are in trunk r1760059.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            Tanmay Tanmay Muley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development