Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7973

Add standard services for WorkEffortAttribute creation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: workeffort
    • Labels:
      None

      Description

      This patch add entity-auto services for WorkEffortAttribute

      1. OFBIZ-7973_Screens.patch
        9 kB
        Leila Mekika
      2. OFBIZ-7973.patch
        2 kB
        Leila Mekika

        Activity

        Hide
        taher Taher Alkhateeb added a comment -

        Thank you for your work Leila, your patch is submitted in r1757689. I tested all services and they work on my machine, nice work.

        It would be great if you can help us out on the user interface level by designing the attributes entry screens as well.

        Show
        taher Taher Alkhateeb added a comment - Thank you for your work Leila, your patch is submitted in r1757689. I tested all services and they work on my machine, nice work. It would be great if you can help us out on the user interface level by designing the attributes entry screens as well.
        Hide
        mleila Leila Mekika added a comment -

        Thank's Taher for the fast commit

        yes, i will try to make the patch for the corresponding screen(s)

        Show
        mleila Leila Mekika added a comment - Thank's Taher for the fast commit yes, i will try to make the patch for the corresponding screen(s)
        Hide
        mleila Leila Mekika added a comment -

        Here is he patch that add WorkEffortAttribute screens in WorkEffort component.

        Show
        mleila Leila Mekika added a comment - Here is he patch that add WorkEffortAttribute screens in WorkEffort component.
        Hide
        taher Taher Alkhateeb added a comment -

        Hi Leila, I tested all your work again and it looks great. Well done and thank you, your work is committed in r1757822 with minor changes:

        • Some indentation formatting
        • Added Arabic translation to the new labels.
        Show
        taher Taher Alkhateeb added a comment - Hi Leila, I tested all your work again and it looks great. Well done and thank you, your work is committed in r1757822 with minor changes: Some indentation formatting Added Arabic translation to the new labels.
        Hide
        soledad Nicolas Malin added a comment -

        I just simplify the submit button definition on 1757832.

        Just for sharing :

        <field name="updateButton"><submit/></field>

        -> Call FormFieldTitle_updateButton present on CommonUiLabels and by default the submit element take the attribute button-type="button".

        So

        <field name="submitButton" title="${uiLabelMap.CommonUpdate}"><submit button-type="button"/></field>

        would be come

        <field name="updateButton"><submit/></field>
        Show
        soledad Nicolas Malin added a comment - I just simplify the submit button definition on 1757832. Just for sharing : <field name= "updateButton" ><submit/></field> -> Call FormFieldTitle_updateButton present on CommonUiLabels and by default the submit element take the attribute button-type="button". So <field name= "submitButton" title= "${uiLabelMap.CommonUpdate}" ><submit button-type= "button" /></field> would be come <field name= "updateButton" ><submit/></field>
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Should we not close?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Should we not close?
        Hide
        deepak.dixit Deepak Dixit added a comment -

        I think we can close this issue.

        Show
        deepak.dixit Deepak Dixit added a comment - I think we can close this issue.

          People

          • Assignee:
            taher Taher Alkhateeb
            Reporter:
            mleila Leila Mekika
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development