Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-1319 Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally
  3. OFBIZ-7720

One generic functionality for select all checkbox by removing currently written multiple functionality

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Trunk
    • 16.11.01
    • framework
    • None
    • Bug Crush Event - 21/2/2015, Community Day 3 - 2016

    Description

      We have many occurrence of selectAll, toggleAll abd checkToggle function calling in ftls. Example:

      // For selecting all the child checkboxes
      <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, '${selectAllFormName}');"/>
      
      // For selecting the child checkboxes and parent (if all child boxes is selected)
      <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="Y" onclick="javascript:checkToggle(this, '${selectAllFormName}');"/>
      
      // For selecting all the child checkboxes if parent checbox is selected on page load.
      <script language="JavaScript" type="text/javascript">selectAll('selectAllForm');</script>
      

      Above all functionality should be replaced using one generic utility of selectAll. Example:

      // One class "selectAll" on parent checkbox will handle all above cases.
      <input type="checkbox" name="selectAll" value="Y" class="selectAll"/>
      

      Attachments

        1. OFBIZ-7720.patch
          4 kB
          Amardeep Singh Jhajj

        Activity

          People

            pandeypranay Pranay Pandey
            amardeepsj Amardeep Singh Jhajj
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: