Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7553

On order list page, the 'All' checkbox for status field does not work properly

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 16.11.01
    • Fix Version/s: 16.11.01
    • Component/s: order
    • Labels:
      None

      Description

      Steps to generate:

      1) Go to order list page.
      2) For status field, check the 'All' checkbox. This will check all the other status checkboxes.
      3) Now uncheck any one or more checkbox other than 'All'.

      • Expected: This should uncheck the 'All' checkbox also.
      • Actual: 'All' checkbox remains checked.

      Please see the screenshot

      1. OFBIZ-7553.patch
        5 kB
        Mohammad Kathawala
      2. Screenshot.png
        157 kB
        Mohammad Kathawala

        Activity

        Hide
        Mohammad K Mohammad Kathawala added a comment -

        Attached patch.

        • Used replaced old js code with jQuery code.
        • Added js function which will watch for statuses of all checkbox other than 'All' and change the 'All' status checkbox accordingly.
        • Added class on checkboxes other than 'All' checkbox in order to bind the change event in jQuery.
        • Also added id on 'All' checkbox to bind its change event in jQuery.
        Show
        Mohammad K Mohammad Kathawala added a comment - Attached patch. Used replaced old js code with jQuery code. Added js function which will watch for statuses of all checkbox other than 'All' and change the 'All' status checkbox accordingly. Added class on checkboxes other than 'All' checkbox in order to bind the change event in jQuery. Also added id on 'All' checkbox to bind its change event in jQuery.
        Hide
        diveshdut Divesh Dutta added a comment -

        Thanks Mohammad Kathawala for your patch. Its committed in trunk in revision number 1751356.

        Show
        diveshdut Divesh Dutta added a comment - Thanks Mohammad Kathawala for your patch. Its committed in trunk in revision number 1751356.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        HI Divesh, Mohammad,

        Is this a bug or an improvement? If it's a bug why has it not been backported? Thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - HI Divesh, Mohammad, Is this a bug or an improvement? If it's a bug why has it not been backported? Thanks!
        Hide
        Mohammad K Mohammad Kathawala added a comment -

        Thanks Jacques Le Roux,

        I think it is an improvement as the functionality was already working before the fix. Changing the type to Improvement.

        Show
        Mohammad K Mohammad Kathawala added a comment - Thanks Jacques Le Roux , I think it is an improvement as the functionality was already working before the fix. Changing the type to Improvement.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Mohammad!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Mohammad!

          People

          • Assignee:
            diveshdut Divesh Dutta
            Reporter:
            Mohammad K Mohammad Kathawala
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development