[OFBIZ-7519] Some entity-auto services fields doesn't have optional false in case of multiple PK's

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: accounting, content, marketing
• Assignee: Pranay Pandey
• Reporter: Amardeep Singh Jhajj
• Created: 21/Jun/16 05:44
• Updated: 22/Jun/16 12:36
• Resolved: 21/Jun/16 14:38

Description

Some services with entity-auto doesn't have optional false in case of multiple PK's. In this cases if any of the PK is missing then sql error returns.

Please find attached screenshot of error.

According to my analysis of entity auto engine, Here are some cases:

1. One primary key: Takes new sequence if PK not passed.
2. Two primary key: Both PK should be mandatory except the case of secondary primary key (like agreementItemSeqId) where next subsequence is generated.
3. More than two PK's, all PK's should be mandatory except the fromDate.

Here is the list of services which need to be fixed according to above points.

1. createAgreementItem
2. updateAgreementItem
3. deleteAgreementItem
4. updateAgreementTerm
5. deleteAgreementTerm
6. createContentMetaData
7. createContentPurpose
8. createContentPurposeOperation
9. createContentAttribute
10. createContentRevisionItem
11. createContentTypeAttr
12. createDataResourceMetaData
13. createDataResourcePurpose
14. createSurveyTrigger
15. createDataResourceAttribute
16. createSalesOpportunityRole

I am working on it and will add patch soon.

Issue Links

• is broken by: OFBIZ-5955 Convert Agreement entites CRUD service from simple to entity-auto
• is broken by: OFBIZ-6745 Convert Content entites CRUD service from simple to entity-auto
• relates to: OFBIZ-5800 Manage multi pk with sub-sequence on entity-auto