[OFBIZ-7410] Enforce noninstantiability to BirtWorker Class

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: birt
• Sprint: Community Day 2 - 2016, OFBiz Community Day (May 2020)
• Assignee: Arun Patidar
• Reporter: Arun Patidar
• Created: 18/Jun/16 07:16
• Updated: 27/Jun/16 14:43
• Resolved: 27/Jun/16 14:43

Description

• Make class as final.

• Add a private constructor.

• Make the following public static variables as private

      public final static String BIRT_PARAMETERS = "birtParameters";
      public final static String REPORT_ENGINE = "reportEngine";
      public final static String BIRT_LOCALE = "birtLocale";
      public final static String BIRT_IMAGE_DIRECTORY = "birtImageDirectory";
      public final static String BIRT_CONTENT_TYPE = "birtContentType";
      public final static String BIRT_OUTPUT_FILE_NAME = "birtOutputFileName";
  

• Add get methods for above public variables that changed to private. Also replace the use public static variables with get methods.

  getBirtParameters()
  getBirtLocale()
  getBirtImageDirectory()
  getBirtContentType()
  getBirtOutputFileName()
  

• Make the following private static variable as final.

      private static HTMLServerImageHandler imageHandler = new HTMLServerImageHandler();