[OFBIZ-7346] connection pooling not working

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 14.12.01, 15.12.01
• Component/s: ALL COMPONENTS
• Assignee: Jacques Le Roux
• Reporter: Gareth Carter
• Created: 14/Jun/16 13:03
• Updated: 17/Jun/16 17:25
• Resolved: 17/Jun/16 11:57

Description

Connection pooling does not seem to work. Connections are created fine but as the close() method is called (outside of transaction) or the transaction is committed the connections are closed to the db server and not returned to the pool.

I believe the issue is with org.apache.commons.dbcp2.PoolableConnectionFactory passivateObject method. This will call rollback() when rollbackOnReturn is set to true even if the transaction is committed. This is because any connection wrappers extending org.apache.commons.dbcp2.DelegatingConnection cache autoCommit status. At some point, this cached autoCommit is different from the underlying connection autoCommit. The rollback() method will throw an exception and the connection is destroyed rather than put back to the pool

Environment this has been tested on:
ofbiz: rev 1725574 and latest trunk (as of 2016-06-14)
db: postgresql 9.1
jdbc driver: postgresql-9.3-1101.jdbc4
os: linux and windows

I have asked dev ml for others to check this with other dbs. Jacques has test with postgres but could not see this behaviour

Sub-Tasks

• The Connection Pool Status feature in webtools is broken: Closed