Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7343

Geo Location functionality of facility contact information screen is not working

    Details

      Description

      Steps to regenerate :
      1) Log in into facility application.
      2) Select any facility and go to Contact Information.
      3) Click on "Geo Location" button under Postal Address section.
      4) In a new modal window is open with following error.

      "ERROR rendering error page [/error/error.jsp], but here is the error text: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [geoLocation]; this request does not exist or cannot be called directly. "

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Yes right, thanks Deepak. And indeed we should allow auto-escaping, we have OFBIZ-7675 for that.

        I had a quick look to see if we could not use a modal layer instead of a popup, but it's not obvious to use modal layer from Freemarker. This does not mean that it can't be done... I'll see later...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Yes right, thanks Deepak. And indeed we should allow auto-escaping, we have OFBIZ-7675 for that. I had a quick look to see if we could not use a modal layer instead of a popup, but it's not obvious to use modal layer from Freemarker. This does not mean that it can't be done... I'll see later...
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Pawan for your contribution
        Your Patch has been committed at
        Trunk at r#1759024
        15.12 at r#1759028
        14.12 at r#1759029

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Pawan for your contribution Your Patch has been committed at Trunk at r#1759024 15.12 at r#1759028 14.12 at r#1759029
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Jacques,

        I think we can use ?html escape sequence, its deprecated and Auto-escaping and output formats should be used but as we did not enabled the auto-escaping so for this case I am using html for escaping.

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Jacques, I think we can use ?html escape sequence, its deprecated and Auto-escaping and output formats should be used but as we did not enabled the auto-escaping so for this case I am using html for escaping.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pawan,

        I did not commit yet, because when in French I got this js error message in console (else nothing apears anywhere)

        SyntaxError: missing ) after argument list
        ...=9000&partyId=Company', 'Adresse d'expédition - Géolocalisation', '450', '550')
        

        It's due to the quote in "Adresse d'expédition"
        We could though commit by escaping the popUptitle, but I also think we should change from the popup (and everywhere the same is used) to a modal layered window.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pawan, I did not commit yet, because when in French I got this js error message in console (else nothing apears anywhere) SyntaxError: missing ) after argument list ...=9000&partyId=Company', 'Adresse d'expédition - Géolocalisation', '450', '550') It's due to the quote in "Adresse d'expédition" We could though commit by escaping the popUptitle, but I also think we should change from the popup (and everywhere the same is used) to a modal layered window.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Oh sorry Pawan, I completely missed your point, seems I did not read the 2nd bullet :/

        Show
        jacques.le.roux Jacques Le Roux added a comment - Oh sorry Pawan, I completely missed your point, seems I did not read the 2nd bullet :/
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pawan, but I don't think it fits. We should not use the GetPartyGeoLocation view to render a facility location. We have the Facility.geoPointId Entity.field and we should use that rather. Not sure how it was handled then, but this was working in R13.07 and R12.04 see https://ofbiz-vm.apache.org:28443/facility/control/EditFacilityGeoPoint?facilityId=WebStoreWarehouse

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pawan, but I don't think it fits. We should not use the GetPartyGeoLocation view to render a facility location. We have the Facility.geoPointId Entity.field and we should use that rather. Not sure how it was handled then, but this was working in R13.07 and R12.04 see https://ofbiz-vm.apache.org:28443/facility/control/EditFacilityGeoPoint?facilityId=WebStoreWarehouse
        Hide
        pawan.verma Pawan Verma added a comment -

        Attaching patch to show geo location at facility contact information screen.

        Show
        pawan.verma Pawan Verma added a comment - Attaching patch to show geo location at facility contact information screen.

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            pawan.verma Pawan Verma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development