Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: birt, order
    • Labels:
      None

      Description

      Net Before Overhead Report is not working
      Screen : https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
      Section : Net Before Overhead Report
      Getting error like

         [java] org.eclipse.birt.report.engine.api.impl.ParameterValidationException: The type of parameter "DateYear" is expected as "integer", not "java.lang.String".
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask.validateParameterValueType(EngineTask.java:940) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask.validateAbstractScalarParameter(EngineTask.java:862) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask.access$0(EngineTask.java:789) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterValidationVisitor.visitScalarParameter(EngineTask.java:706) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterVisitor.visit(EngineTask.java:1531) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.EngineTask.doValidateParameters(EngineTask.java:692) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.doRun(RunAndRenderTask.java:95) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.run(RunAndRenderTask.java:77) ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
           [java] 	at org.ofbiz.birt.BirtWorker.exportReport(BirtWorker.java:143) ~[ofbiz-birt.jar:?]
           [java] 	at org.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:118) ~[ofbiz-birt.jar:?]
           [java] 	at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) ~[ofbiz-webapp.jar:?]
           [java] 	at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) ~[ofbiz-webapp.jar:?]
           [java] 	at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) [ofbiz-webapp.jar:?]
           [java] 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) [servlet-api-3.1.jar:?]
           [java] 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) [servlet-api-3.1.jar:?]
           [java] 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:323) [ofbiz-webapp.jar:?]
           [java] 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:522) [tomcat-8.0.33-catalina.jar:8.0.33]
           [java] 	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1095) [tomcat-8.0.33-tomcat-coyote.jar:8.0.33]
           [java] 	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:672) [tomcat-8.0.33-tomcat-coyote.jar:8.0.33]
           [java] 	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1502) [tomcat-8.0.33-tomcat-coyote.jar:8.0.33]
           [java] 	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1458) [tomcat-8.0.33-tomcat-coyote.jar:8.0.33]
           [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_66]
           [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_66]
           [java] 	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-8.0.33-tomcat-util.jar:8.0.33]
           [java] 	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
      
      1. error.logs
        16 kB
        Rohit Koushal
      2. OFBIZ-7317.patch
        571 kB
        Rohit Koushal

        Activity

        Hide
        rohit.koushal Rohit Koushal added a comment - - edited

        Found various problem under this report
        1. Type miss-match between parameter defined in the report and the passed parameters. Just because of that we are getting an exception like The type of parameter "DateYear" is expected as "integer", not "java.lang.String".
        2. This report totally depends on demo data provided under the SalesOrderItems applications/order/data/SalesOrderDemoData.xml.
        3. This report has lots of hard coded check and values based on SalesOrderDemoData.xml data .
        4. There are too many non-existing fields(like eBay, RRC, OtherFree and NBO etc) which we tried to get from entity SalesOrderItemStarSchema.

        I didn't find any documentation of this report over the confluence, In my opinion, we need to remove this report as its foundation totally depends on the demo data.

        Show
        rohit.koushal Rohit Koushal added a comment - - edited Found various problem under this report 1. Type miss-match between parameter defined in the report and the passed parameters. Just because of that we are getting an exception like The type of parameter "DateYear" is expected as "integer", not "java.lang.String". 2. This report totally depends on demo data provided under the SalesOrderItems applications/order/data/SalesOrderDemoData.xml. 3. This report has lots of hard coded check and values based on SalesOrderDemoData.xml data . 4. There are too many non-existing fields(like eBay, RRC, OtherFree and NBO etc) which we tried to get from entity SalesOrderItemStarSchema. I didn't find any documentation of this report over the confluence, In my opinion, we need to remove this report as its foundation totally depends on the demo data.
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Guys, Any suggestions on this ticket?

        Show
        rohit.koushal Rohit Koushal added a comment - Guys, Any suggestions on this ticket?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I'd say let it go, since nobody cares about it, else please chime in... Without answer here I suggest to get rid of it in 3 days

        Show
        jacques.le.roux Jacques Le Roux added a comment - I'd say let it go, since nobody cares about it, else please chime in... Without answer here I suggest to get rid of it in 3 days
        Hide
        mbrohl Michael Brohl added a comment -

        Hi Rohit Koushal,

        I'm in favor to have this removed from the codebase. It seems to be unfinished, abandonded work.

        Thanks,
        Michael

        Show
        mbrohl Michael Brohl added a comment - Hi Rohit Koushal , I'm in favor to have this removed from the codebase. It seems to be unfinished, abandonded work. Thanks, Michael
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Please Rohit, removes when you get a chance, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Please Rohit, removes when you get a chance, thanks!
        Hide
        rishisolankii Rishi Solanki added a comment -

        +`1 for removing it.

        Show
        rishisolankii Rishi Solanki added a comment - +`1 for removing it.
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Thanks Jacques Le Roux and Michael Brohl

        Here is the patch that removes the NBO(Net Before Overhead) report from the trunk. In the patch I have also removed the Demo data which is required by this report only. Please review it and let me know if you people have any issue.

        Note : Please remove below data from existing database to avoid any data related problem.

        OrderPortletData.xml
            <PortalPortlet portalPortletId="NBO_Report"
                           portletName="Net Before Overhead Report"
                           screenName="NetBeforeOverheadReport"
                           screenLocation="component://birt/widget/order/OrderScreens.xml"
                           description=""/>
            <PortletPortletCategory portalPortletId="NBO_Report" portletCategoryId="REPORT"/>
            <PortalPagePortlet portalPageId="OrderReportPage" portalPortletId="NBO_Report" portletSeqId="00001" columnSeqId="00002" sequenceNum="11"/>
        
        Show
        rohit.koushal Rohit Koushal added a comment - Thanks Jacques Le Roux and Michael Brohl Here is the patch that removes the NBO(Net Before Overhead) report from the trunk. In the patch I have also removed the Demo data which is required by this report only. Please review it and let me know if you people have any issue. Note : Please remove below data from existing database to avoid any data related problem. OrderPortletData.xml <PortalPortlet portalPortletId= "NBO_Report" portletName= "Net Before Overhead Report" screenName= "NetBeforeOverheadReport" screenLocation= "component: //birt/widget/order/OrderScreens.xml" description=""/> <PortletPortletCategory portalPortletId= "NBO_Report" portletCategoryId= "REPORT" /> <PortalPagePortlet portalPageId= "OrderReportPage" portalPortletId= "NBO_Report" portletSeqId= "00001" columnSeqId= "00002" sequenceNum= "11" />
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Rohit, I did not check further, but are not the "B2CStore" data also needed by the Product Demand Report?
        http://svn.apache.org/viewvc?view=revision&revision=902719

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Rohit, I did not check further, but are not the "B2CStore" data also needed by the Product Demand Report? http://svn.apache.org/viewvc?view=revision&revision=902719
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Thanks for the pointer Jacques Le Roux, I quickly checked and found that report is independent of removed data. In Product Demand Report we have the option to select the ProductStore.

        Show
        rohit.koushal Rohit Koushal added a comment - Thanks for the pointer Jacques Le Roux , I quickly checked and found that report is independent of removed data. In Product Demand Report we have the option to select the ProductStore.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Rohit, we are also able to select the ProductStore in Net Before Overhead Report, but we already agreed about removing it anyway.

        Before committing, I'd like to be sure to understand what happens with the Product Demand Report. Because when I create new orders I don't see anything in this report for the ecommerce store, even after seeding the BI data. I did not digg further but that sounds weird to me. Could you please double check OFBIZ-7316 is OK, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Rohit, we are also able to select the ProductStore in Net Before Overhead Report, but we already agreed about removing it anyway. Before committing, I'd like to be sure to understand what happens with the Product Demand Report. Because when I create new orders I don't see anything in this report for the ecommerce store, even after seeding the BI data. I did not digg further but that sounds weird to me. Could you please double check OFBIZ-7316 is OK, thanks!
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Hi Jacques Le Roux,

        I placed two orders #WSCO10000(Back-End) & #WSCO10001(e-commerce) after running the service quickInitDataWarehouse and I am able to generate the Product Demand Report corresponding to those orders.

        The only thing which I observed when we run the quickInitDataWarehouse for the long date range(40 years) it causes transaction timeout. I suspect this might be the reason which causes issue at your end. Attaching the server logs (ofbiz-vm.apache.org:8443) for your reference.

        In my opinion, we need to increase the transaction timeout of quickInitDataWarehouse service. So can I raise one ticket on behalf of it ?

        Show
        rohit.koushal Rohit Koushal added a comment - Hi Jacques Le Roux , I placed two orders #WSCO10000 (Back-End) & #WSCO10001 (e-commerce) after running the service quickInitDataWarehouse and I am able to generate the Product Demand Report corresponding to those orders. The only thing which I observed when we run the quickInitDataWarehouse for the long date range(40 years) it causes transaction timeout. I suspect this might be the reason which causes issue at your end. Attaching the server logs (ofbiz-vm.apache.org:8443) for your reference. In my opinion, we need to increase the transaction timeout of quickInitDataWarehouse service. So can I raise one ticket on behalf of it ?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Rohit,

        I confirm it works not only as you showed in trunk demo but also locally.

        Not sure what happened to me last time. I ran the quickInitDataWarehouse service after creating an order but also created one after. Anyway it surely works so better to forget it.

        Your patch is in trunk at revision: 1763132. I did not backport, too much conflicts.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Rohit, I confirm it works not only as you showed in trunk demo but also locally. Not sure what happened to me last time. I ran the quickInitDataWarehouse service after creating an order but also created one after. Anyway it surely works so better to forget it. Your patch is in trunk at revision: 1763132. I did not backport, too much conflicts.
        Hide
        rohit.koushal Rohit Koushal added a comment -
        Show
        rohit.koushal Rohit Koushal added a comment - Thanks Jacques Le Roux .

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            rohit.koushal Rohit Koushal
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development