Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7168

Run MRP shows all type of facilities

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: manufacturing
    • Labels:
      None

      Description

      When we go to Run MRP screen, all types of facilities (including facilities with no type) are listed here in the Facility drop down.

      I think, It's better to list only WAREHOUSE or some specific type of facilities. Basically, there is no meaning of showing facilities which don't have proper type or type is not available for e.g. CALL_CENTER, FLOOR etc.

      Let me know if anyone have any thoughts on this. Thanks!

        Activity

        Hide
        mridul.pathak Mridul Pathak added a comment - - edited

        Committed this change in trunk r1752893 as no further concerns were raised.
        Thanks Sanjay Yadav for reporting the issue and Ankit Joshi for providing the patch. Thanks Pierre Smits for review.

        Show
        mridul.pathak Mridul Pathak added a comment - - edited Committed this change in trunk r1752893 as no further concerns were raised. Thanks Sanjay Yadav for reporting the issue and Ankit Joshi for providing the patch. Thanks Pierre Smits for review.
        Hide
        mridul.pathak Mridul Pathak added a comment -

        Hi Pierre Smits,

        Your suggestion looks good, but introducing system property seems more appropriate when we need to avoid a functional change that uses hard coded filtering. This patch is just a UI change, and with current OOTB facility types seems alright. UI is easily customizable in OFBiz if needs to be, and as per my understanding introducing system property for UI should be avoided in general.

        Show
        mridul.pathak Mridul Pathak added a comment - Hi Pierre Smits , Your suggestion looks good, but introducing system property seems more appropriate when we need to avoid a functional change that uses hard coded filtering. This patch is just a UI change, and with current OOTB facility types seems alright. UI is easily customizable in OFBiz if needs to be, and as per my understanding introducing system property for UI should be avoided in general.
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch means that we are introducing a hard coded filtering aspect.
        Shouldn't this a configurable aspect. Meaning, we could define this a value (see the example below, but don't fret over the value in systemPropertyId as it is just an example) stored in the SystemProperty entity - with a fall back to a component specific .properties file, and retrieve it from there as the default.

        <SystemProperty description="Default Facility Type(s) for Facility selection in MRP planning" systemPropertyId="mpr.facilityType.default" systemPropertyValue="WAREHOUSE, MFG-FACILITY" systemResourceId="manufacturing"/>
        
        Show
        pfm.smits Pierre Smits added a comment - This patch means that we are introducing a hard coded filtering aspect. Shouldn't this a configurable aspect. Meaning, we could define this a value (see the example below, but don't fret over the value in systemPropertyId as it is just an example) stored in the SystemProperty entity - with a fall back to a component specific .properties file, and retrieve it from there as the default. <SystemProperty description= "Default Facility Type(s) for Facility selection in MRP planning" systemPropertyId= "mpr.facilityType. default " systemPropertyValue= "WAREHOUSE, MFG-FACILITY" systemResourceId= "manufacturing" />
        Hide
        ankit.joshi Ankit Joshi added a comment -

        Here is the patch to list only 'WAREHOUSE' type of facilities for Run MRP functionality.

        Show
        ankit.joshi Ankit Joshi added a comment - Here is the patch to list only 'WAREHOUSE' type of facilities for Run MRP functionality.
        Hide
        pandeypranay Pranay Pandey added a comment - - edited

        Thanks for suggesting this improvement Sanjay. Yes this is a good one to have.

        Show
        pandeypranay Pranay Pandey added a comment - - edited Thanks for suggesting this improvement Sanjay. Yes this is a good one to have.

          People

          • Assignee:
            mridul.pathak Mridul Pathak
            Reporter:
            sanjay.yadav@hotwaxsystems.com Sanjay Yadav
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development