In getInvoiceAddressByType() method of InvoiceWorker, it is fetching address from PartyContactWithPurpose in case of empty InvoiceContactMech.
This method calls from two methods getBillToAddress() and getSendFromAddress() of same class.
Here, my concerns are:
- There is no way to check that returned address is invoice associated address or party address. It is misleading.
- There is no control of user to get the address linked to invoice only.
My proposals is:
1). System should return party address only if user really demand for it. We can override method and pass additional parameter for achieving this. Systems default behavior should same as current.