Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7122

Showing Invoice address from PartyContactMech

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting
    • Labels:
      None

      Description

      In getInvoiceAddressByType() method of InvoiceWorker, it is fetching address from PartyContactWithPurpose in case of empty InvoiceContactMech.
      This method calls from two methods getBillToAddress() and getSendFromAddress() of same class.

      Here, my concerns are:

      • There is no way to check that returned address is invoice associated address or party address. It is misleading.
      • There is no control of user to get the address linked to invoice only.

      My proposals is:
      1). System should return party address only if user really demand for it. We can override method and pass additional parameter for achieving this. Systems default behavior should same as current.

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        +1

        Show
        jacques.le.roux Jacques Le Roux added a comment - +1
        Hide
        rahul.kushwah Rahul Singh added a comment -

        Adding patch to address this issue.

        Show
        rahul.kushwah Rahul Singh added a comment - Adding patch to address this issue.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1749888

        Thanks Rahul Singh for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1749888 Thanks Rahul Singh for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            arunpati Arun Patidar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development