Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7010

Shipping method is shown on all Promo Conditions even when only a single condition includes Shipping Method

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 13.07, Release Branch 14.12, Release Branch 15.12, Trunk
    • Fix Version/s: 14.12.01, 15.12.01, 13.07.04
    • Component/s: product
    • Labels:
      None

      Description

      If we create any Promo condition by selecting any Shipping Method.

      Now for all the conditions, we create after this, automatically includes the previously selected Shipping Method.
      ___________________________________________________________

      Reason:

      Basically, it's a UI issue, the Promo Condition created in the database are correct.

      In EditProductPromoRules.ftl, we assign 'carrierShippingMethod' and 'carrierParty' in iteration with the Promotion condition 'productPromoConds'

      <#list productPromoConds as productPromoCond>
      ...
         <#assign carrierShippingMethod = productPromoCond.otherValue!>
      ...
      

      ___________________________________________________________

      Solution:

      Before assigning the 'carrierShippingMethod' and 'carrierParty' from Promo Condition, reset the previously set value.
      for e.g.

      <#assign carrierShippingMethod = ""/>
      <#if otherValue?has_content && otherValue.contains("@")>
        <#assign carrierShippingMethod = productPromoCond.otherValue!>
      </#if>
      

        Attachments

        1. OFBIZ-7010.patch
          1 kB
          Swapnil Mane
        2. OFBIZ-7010-For1307.patch
          1 kB
          Swapnil Mane

          Activity

            People

            • Assignee:
              mridulpathak Mridul Pathak
              Reporter:
              swapnilmmane Swapnil Mane
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: