Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6966

Unable to change language in ecommerce

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ecommerce
    • Labels:
      None

      Description

      Problem
      =======
      Go to http://localhost:8080/ecommerce/
      Change the language dropdown from English to another language will revert back to English. I am using SVN revision 1735923

      1. OFBIZ-6966.patch
        2 kB
        James Yong
      2. OFBIZ-6966.version2.patch
        2 kB
        James Yong

        Issue Links

          Activity

          Hide
          jamesyong James Yong added a comment -

          That's great

          Show
          jamesyong James Yong added a comment - That's great
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          As expected this work in trunk demo, well done!

          Show
          jacques.le.roux Jacques Le Roux added a comment - As expected this work in trunk demo, well done!
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks James,

          Your patch is in trunk at revision: 1737046

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks James, Your patch is in trunk at revision: 1737046
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          That's better indeed. As soon as you start with HTTPS instead of HTTP it works. So I guess it will work on demo, I will commit it, thanks!
          I will close only after checking on demo tomorrow.

          I wonder if it will have an impact on the issue I explain at https://issues.apache.org/jira/browse/OFBIZ-6849?focusedCommentId=15139418. I will test that after the commit...

          BTW, better to keep the same patch name, the olders will be grayed, so it's obvious which version is last and several paches lines can be used (happens sometimes)
          It's another trick you can find in https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices

          Show
          jacques.le.roux Jacques Le Roux added a comment - That's better indeed. As soon as you start with HTTPS instead of HTTP it works. So I guess it will work on demo, I will commit it, thanks! I will close only after checking on demo tomorrow. I wonder if it will have an impact on the issue I explain at https://issues.apache.org/jira/browse/OFBIZ-6849?focusedCommentId=15139418 . I will test that after the commit... BTW, better to keep the same patch name, the olders will be grayed, so it's obvious which version is last and several paches lines can be used (happens sometimes) It's another trick you can find in https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
          Hide
          jamesyong James Yong added a comment -

          I come up with an improved version. Didn't test with a proxy.

          Show
          jamesyong James Yong added a comment - I come up with an improved version. Didn't test with a proxy.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Also you might check it works with previous version. For instance the stable demo https://demo-stable-ofbiz.apache.org/ecommerce/control/main.
          As you rightly noticed this is certainly due (not checked yet) to OFBIZ-6879. Something we could do is revert the OFBIZ-6879 change in the meantime and reapply it, with the one here when, OFBIZ-6849 is done. For me the trunk being bleeding edge I'd wait, but I'm curious about the community opinion...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Also you might check it works with previous version. For instance the stable demo https://demo-stable-ofbiz.apache.org/ecommerce/control/main . As you rightly noticed this is certainly due (not checked yet) to OFBIZ-6879 . Something we could do is revert the OFBIZ-6879 change in the meantime and reapply it, with the one here when, OFBIZ-6849 is done. For me the trunk being bleeding edge I'd wait, but I'm curious about the community opinion...
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Actually I checked in trunk demo and it works there https://demo-trunk-ofbiz.apache.org/ecommerce/control/main
          But you are right not locally. I guess it works on the demo because of the frontend proxy which propagates HTTPS

          I agree the change is needed but works only with HTTPS. So it's a good change but it's not enough. Because all the other links are HTTP for now in ecommerce and when you click on one you get back to English (like main page). It works well on trunk were all is HTTPS. I'm working on a solution for that but it's not yet ready: OFBIZ-6849

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Actually I checked in trunk demo and it works there https://demo-trunk-ofbiz.apache.org/ecommerce/control/main But you are right not locally. I guess it works on the demo because of the frontend proxy which propagates HTTPS I agree the change is needed but works only with HTTPS. So it's a good change but it's not enough. Because all the other links are HTTP for now in ecommerce and when you click on one you get back to English (like main page). It works well on trunk were all is HTTPS. I'm working on a solution for that but it's not yet ready: OFBIZ-6849
          Hide
          jamesyong James Yong added a comment -

          Nice feature
          Thanks!

          Show
          jamesyong James Yong added a comment - Nice feature Thanks!
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Thanks,

          Rather than [https://issues.apache.org/jira/browse/OFBIZ-6879], use OFBIZ-6879 it works as well and allows to know the status

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Thanks, Rather than [https://issues.apache.org/jira/browse/OFBIZ-6879], use OFBIZ-6879 it works as well and allows to know the status
          Hide
          jamesyong James Yong added a comment - - edited

          According to OFBIZ-6879, I try from https://127.0.0.1:8443/ecommerce/ and run into the same issue.

          Will provide a patch later.

          Show
          jamesyong James Yong added a comment - - edited According to OFBIZ-6879 , I try from https://127.0.0.1:8443/ecommerce/ and run into the same issue. Will provide a patch later.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              jamesyong James Yong
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development