[OFBIZ-6895] Product price rule with no conditions.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Done
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: product
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 14/Feb/16 20:25
• Updated: 21/May/16 11:15
• Resolved: 21/May/16 11:15

Description

I'm currently closing pending stuff, here is one

Skip reported this 2 years ago on user ML:

I recently had a user accidentially create a product price rule with no
conditions. This resulted in all products sold afterwards getting the
discounted price (-5% price) set by the action.

After tracking this down, I added some code in PriceServices.java to check
if there were no price conditions and if so, set the local variable alltrue
to false. This fixes it for me.

I am debating whether or not to add a Jira for this issue. Was this
intended and can anyone see any value in this behavior?

Skip

I then answered

I'd create a Jira. It looks like a miss to me, the check you do seems good. I'd
also prevent users to create such rules from UI
Maybe we could add a properties, in case someone would like to use a such
scenario (could be used for temporarily give a percent on all products)?

Jacques