[OFBIZ-6888] GroovyEngine.serviceInvoker masks Groovy script exceptions in some cases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 13.07, Release Branch 14.12, Release Branch 15.12, Trunk
• Fix Version/s: 14.12.01, 12.04.06, 13.07.03, 16.11.01
• Component/s: framework
• Labels: errorhandling
• Flags: Patch
• Assignee: Jacques Le Roux
• Reporter: Forrest Rae
• Created: 09/Feb/16 23:39
• Updated: 09/Mar/16 15:39
• Resolved: 09/Mar/16 15:39

Description

If GroovyEngine.serviceInvoker catches an exception in a Groovy script, it would mask the exception in some cases. An exception's detailMessage can be null. If it is null, the exception won't be properly returned and logged, and that will make spotting problems very difficult. This was the case for me while trying to track down a problem with a java.util.ConcurrentModificationException error in a Groovy script. I suspect that this choice to mask exceptions and only return the message has cause bugs to not be spotted.

Disabling this for now in favor of returning a proper exception. GroovyEngine.serviceInvoker() should throw GenericServiceException if error, rather than returning ServiceUtil.returnError(e.getMessage())

Issue Links

• is depended upon by: OFBIZ-6218 Unit tests throw exception in DBCP