Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6873

Convert some Product entites CRUD service from simple to entity-auto

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:

      Description

      I converted the follow entities the simple service crud to entity-auto :

      • ProductPaymentMethodType
      • SupplierProduct
      • CommunicationEventProduct
      • ProductCategoryMember
      • ProductFeatureDataResource
      • ProductConfig
      • ProductConfigItem
      • ProductConfigOption
      • ProductConfigProduct
      • ProductPriceRule
      • ProductPriceAction
      • PhysicalInventory
      • ProductFacilityLocation
      • Facility
      • FacilityLocation
      • FacilityGroupMember
      • FacilityGroupRollup
      • FacilityParty
      • FacilityContent
      • InventoryItemLabelType
      • InventoryItemLabelAppl
      • InventoryItemLabel
      • ProductPromo
      • ProductPromoCode
      • ProductPromoCategory
      • ProductPromoCodeEmail
      • ProductPromoCodeParty
      • ProductPromoProduct
      • ProductPromoRule

      I added a new permission service productPriceGenericPermission to manage all related price service.
      I try to convert saveProductPriceChange service but the fields changed* didn't manage by th entity-auto service. I will check the engine.

        Activity

        Hide
        soledad Nicolas Malin added a comment -

        Done on trunk at revision 1728261

        Show
        soledad Nicolas Malin added a comment - Done on trunk at revision 1728261
        Hide
        pfm.smits Pierre Smits added a comment -

        Various entities affected have a lifespan definition (from and trhu dates). So deletion of records of these entities is not the correct solution from a GRC viewpoint. Have you taken this into considerations when transforming the services?

        Show
        pfm.smits Pierre Smits added a comment - Various entities affected have a lifespan definition (from and trhu dates). So deletion of records of these entities is not the correct solution from a GRC viewpoint. Have you taken this into considerations when transforming the services?
        Hide
        soledad Nicolas Malin added a comment -

        Completely pierre, and is the reason that I use update instead of delete some time, when I detect this.

        I recheck my commit, but I didn't found this case.

        During the service conversion I think we have a missing on the entity-auto. We would be add the invoke cancel to manage directly the lifespan

        Show
        soledad Nicolas Malin added a comment - Completely pierre, and is the reason that I use update instead of delete some time, when I detect this. I recheck my commit, but I didn't found this case. During the service conversion I think we have a missing on the entity-auto. We would be add the invoke cancel to manage directly the lifespan

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            soledad Nicolas Malin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development