OFBiz
  1. OFBiz
  2. OFBIZ-68

Break up application templates with multiple screenlets

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are:

      entry/cart/showcart.ftl
      entry/cart/showPromotionDetails.ftl
      entry/order/orderheader.ftl
      entry/poheader.ftl (may not be used)
      order/orderheader.ftl
      quote/ViewQuoteInfo.ftl
      request/ViewRequestInfo.ftl

      I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole.

      Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks

      1. ViewRequest.patch
        28 kB
        Chris Howe
      2. ViewQuote.patch
        29 kB
        Chris Howe
      3. showPromotionDetails.patch
        20 kB
        Chris Howe
      4. OrderOrderHeader.patch
        116 kB
        Chris Howe
      5. OrderEntryOrderHeader.patch
        33 kB
        Chris Howe
      6. cssChange.patch
        2 kB
        Chris Howe

        Activity

          People

          • Assignee:
            Jacopo Cappellato
            Reporter:
            Chris Howe
          • Votes:
            3 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development