Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6782

Service parameter should be required.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 12.04, Release Branch 13.07
    • Fix Version/s: 12.04.06, 13.07.03
    • Component/s: accounting
    • Labels:
      None
    • Flags:
      Important

      Description

      There is no null check on one of parameters "itemShippingList" of calcTax service implemented in TaxAuthorityServices.java by name of rateProductTaxCalc.
      Now this parameter should either be made required in service defination in services_tax.xml or null check should be present just like the other parameters like itemQuantity have.
      because when i am trying to run this service with only passing required parameters it is throwing null pointer exception.

        Activity

        Show
        lektran Scott Gray added a comment - Are you sure you're using the 14.12 release? Because it appears to have been fixed already in that branch: Diff: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java?r1=1511742&r2=1534062 Commit: http://svn.apache.org/viewvc?view=revision&revision=1534062
        Hide
        KlwntSingh Kulwant Singh added a comment -

        Sorry,
        Yes it is fixed in 14.12 release branch but not fixed in 13.07 and 12.04 release branch.

        Show
        KlwntSingh Kulwant Singh added a comment - Sorry, Yes it is fixed in 14.12 release branch but not fixed in 13.07 and 12.04 release branch.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This was easily backported at
        R13.07 r1722620
        R12.04 r1722621

        Show
        jacques.le.roux Jacques Le Roux added a comment - This was easily backported at R13.07 r1722620 R12.04 r1722621

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            KlwntSingh Kulwant Singh
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development