Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6706

The Widget-style of a menuItem in his link when the menu is selected

    Details

      Description

      This impact the menu style.
      When a widget-style is defined at the menuItem level, and the menuItem is selected, the widget-style of the item is pushed in the link level of the menuItem.

      Adrian explain that :

      In the "old days" screen widgets had styles assigned at a very granular level. Around 2007 or so, that was changed so only a widget's container (an HTML <div> for example) was styled, and the elements it contained were styled with descendent CSS selectors (CSS inheritance).

      You can see that concept at work here:

      https://cwiki.apache.org/confluence/display/OFBADMIN/HTML+and+CSS+Best+Practices

      "...styles should be applied to containers, and the container's style should style all of the elements it contains."

      and here:

      https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles

      Don't assume the widget code is correct. It may be in need of an update.

      1. JIRA-6706-14.12.patch
        2 kB
        Julien NICOLAS
      2. JIRA-6706-13.07.patch
        2 kB
        Julien NICOLAS
      3. JIRA-6706.patch
        2 kB
        Julien NICOLAS

        Activity

        Hide
        julien.nicolas Julien NICOLAS added a comment -

        It was a question, have I to define "close" or "resolve". You answer it, it's both

        Thanks Jacques!

        Show
        julien.nicolas Julien NICOLAS added a comment - It was a question, have I to define "close" or "resolve". You answer it, it's both Thanks Jacques!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        From a simple review (ie no tests) I assume this should be closed

        Show
        jacques.le.roux Jacques Le Roux added a comment - From a simple review (ie no tests) I assume this should be closed
        Hide
        julien.nicolas Julien NICOLAS added a comment -

        This issue is fixed in following releases :
        13.07 r1720907
        14.12 r1720933
        trunk r1720891

        Show
        julien.nicolas Julien NICOLAS added a comment - This issue is fixed in following releases : 13.07 r1720907 14.12 r1720933 trunk r1720891
        Hide
        julien.nicolas Julien NICOLAS added a comment -

        fix for 14.12

        Show
        julien.nicolas Julien NICOLAS added a comment - fix for 14.12
        Hide
        julien.nicolas Julien NICOLAS added a comment -

        fix for 13.07

        Show
        julien.nicolas Julien NICOLAS added a comment - fix for 13.07
        Hide
        julien.nicolas Julien NICOLAS added a comment -

        This is the fix

        Show
        julien.nicolas Julien NICOLAS added a comment - This is the fix

          People

          • Assignee:
            julien.nicolas Julien NICOLAS
            Reporter:
            julien.nicolas Julien NICOLAS
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development