Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6632

Incorrect comparison in TemporalExpressionWorker.java

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 14.12, 16.11.01
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.03
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 3 - 2015

      Description

      Line 128 in TemporalExpressionWorker.java does incorrect comparison

      if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) {
      

      should be

      if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) {
      

      Also documentation of field exprAssocType in entity definition of TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be INCLUDE & EXCLUDE respectively.

        Activity

        Hide
        mbecker Martin Becker added a comment -

        Fixed the entitymodel.xml comment and the comparison in TemporalExpressionWorker and added constants for the three mentioned values.
        Maybe a Java Enum or the use of the OFBiz Enumeration for referential integrity in database may be a more complete solution.

        Show
        mbecker Martin Becker added a comment - Fixed the entitymodel.xml comment and the comparison in TemporalExpressionWorker and added constants for the three mentioned values. Maybe a Java Enum or the use of the OFBiz Enumeration for referential integrity in database may be a more complete solution.
        Hide
        mbrohl Michael Brohl added a comment -

        This is fixed in
        trunk r1704043
        release branch 14.12 r1704044

        Thanks Vyom and Martin!

        Show
        mbrohl Michael Brohl added a comment - This is fixed in trunk r1704043 release branch 14.12 r1704044 Thanks Vyom and Martin!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Backported in
        R13.07 r1704064
        R12.04 r1704065

        Show
        jacques.le.roux Jacques Le Roux added a comment - Backported in R13.07 r1704064 R12.04 r1704065

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            vyom0213@gmail.com Vyom Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile