OFBiz
  1. OFBiz
  2. OFBIZ-659

Refactoring Create Order process

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Later
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.

      From David's email on Mailing list.
      Just some quick thoughts...

      Following the pattern of the anonymous and other checkout processes
      in the ecommerce app would be a great way to go.

      In the order manager there are various paths through the checkout
      process so we might have, for example, 2 different sets of request-
      map definitions and two different "progress bars", one for sales
      orders and one for purchase orders. These two different sets of high-
      level artifacts can point to the same views, services/events,
      screens, data prep scripts, etc wherever the two processes overlap.

      -David

      My Initial comments
      The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
      1) moving some code that's embedded in Java classes into small simple methods.
      2) Moving process control logic from event handlers to Controller file.

      1. OrderCheckoutProcess.patch
        49 kB
        Mridul Pathak
      2. OrderCheckoutProcess.patch
        130 kB
        Anil K Patel
      3. OrderCheckoutProcess.patch
        117 kB
        Anil K Patel
      4. OrderCheckoutProcess.patch
        117 kB
        Anil K Patel
      5. OrderCheckoutProcess.patch
        115 kB
        Anil K Patel
      6. OrderChekOutProcessRefac.patch
        107 kB
        Anil K Patel
      7. OrderChekOutProcessRefac.patch
        90 kB
        Anil K Patel
      8. OrderChekOutProcessRefac.patch
        45 kB
        Anil K Patel
      9. OrderChekOutProcessRefac.patch
        36 kB
        Anil K Patel
      10. OrderProcessSimpleMethods.patch
        3 kB
        Anil K Patel

        Activity

        Anil K Patel created issue -
        Anil K Patel made changes -
        Field Original Value New Value
        Attachment OrderChekOutProcessRefac.patch [ 12349839 ]
        Anil K Patel made changes -
        Attachment OrderProcessSimpleMethods.patch [ 12351091 ]
        Anil K Patel made changes -
        Attachment OrderChekOutProcessRefac.patch [ 12351305 ]
        Anil K Patel made changes -
        Attachment OrderChekOutProcessRefac.patch [ 12351421 ]
        Anil K Patel made changes -
        Attachment OrderChekOutProcessRefac.patch [ 12351441 ]
        Anil K Patel made changes -
        Attachment OrderCheckoutProcess.patch [ 12352706 ]
        Anil K Patel made changes -
        Attachment OrderCheckoutProcess.patch [ 12352718 ]
        Anil K Patel made changes -
        Attachment OrderCheckoutProcess.patch [ 12352781 ]
        Anil K Patel made changes -
        Attachment OrderCheckoutProcess.patch [ 12353005 ]
        Anil K Patel made changes -
        Assignee Anil K Patel [ anilpatel ]
        Mridul Pathak made changes -
        Attachment OrderChekoutProcess.patch [ 12370752 ]
        Mridul Pathak made changes -
        Attachment OrderChekoutProcess.patch [ 12370752 ]
        Mridul Pathak made changes -
        Attachment OrderCheckoutProcess.patch [ 12370753 ]
        Anil K Patel made changes -
        Link This issue is blocked by OFBIZ-1640 [ OFBIZ-1640 ]
        Anil K Patel made changes -
        Link This issue is blocked by OFBIZ-1640 [ OFBIZ-1640 ]
        Anil K Patel made changes -
        Link This issue is part of OFBIZ-1640 [ OFBIZ-1640 ]
        Vikas Mayur made changes -
        Link This issue is part of OFBIZ-1640 [ OFBIZ-1640 ]
        Gavin made changes -
        Workflow jira [ 12395124 ] OFbiz Workflow [ 12506827 ]
        Jacopo Cappellato made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Later [ 7 ]

          People

          • Assignee:
            Anil K Patel
            Reporter:
            Anil K Patel
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development