Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      OFBIZ-6404 added the ability to embed menus upon which the resolution of this issue will be based.

      Before this issue is started, OFBIZ-6404 patch needs to be modified so that the menus are not rendered in row forms which may get created for row editing purposes, so that menus, screens, forms, and grids can still work if they contain html forms of their own.

      1. OFBIZ-6501.patch
        58 kB
        Nicolas Malin
      2. OFBIZ-6501.patch
        53 kB
        Nicolas Malin
      3. OFBIZ-6501.patch
        43 kB
        Christian Carlow

        Issue Links

          Activity

          Hide
          ofbizzer Christian Carlow added a comment -

          This patch handles menu screen, form, and grid rendering within grid cells.

          It is based on OFBIZ-6404 menu embedding within grids. <field><menu> was changed to <field><include-menu> to be consistent with <include-grid>, <include-screen> etc .

          It also includes logic to ensure unique names and ids are rendered to resolve javascript submit() errors due to identical naming/ids.

          Reviews and feedback are appreciated.

          Show
          ofbizzer Christian Carlow added a comment - This patch handles menu screen, form, and grid rendering within grid cells. It is based on OFBIZ-6404 menu embedding within grids. <field><menu> was changed to <field><include-menu> to be consistent with <include-grid>, <include-screen> etc . It also includes logic to ensure unique names and ids are rendered to resolve javascript submit() errors due to identical naming/ids. Reviews and feedback are appreciated.
          Hide
          ofbizzer Christian Carlow added a comment -

          The patch also incorporates changes to handle OFBIZ-6502.

          Show
          ofbizzer Christian Carlow added a comment - The patch also incorporates changes to handle OFBIZ-6502 .
          Hide
          soledad Nicolas Malin added a comment - - edited

          Christian, I review/update the patch and merge my last improvement on OFBIZ-6404.

          I added example on screen example/control/FindExample of form and screen inclusion.
          Yet I haven't tested the gris inclusion.

          Show
          soledad Nicolas Malin added a comment - - edited Christian, I review/update the patch and merge my last improvement on OFBIZ-6404 . I added example on screen example/control/FindExample of form and screen inclusion. Yet I haven't tested the gris inclusion.
          Hide
          soledad Nicolas Malin added a comment -

          After a second review I added demo data on example and change the FindExample search to display list with an example of :

          • include-form : ListExamplesWithFeatures
          • include-screen : ListExamplesWithItems
          • include-grid : ListExamplesWithStatus

          The include-menu is always available on ListCache.

          Show
          soledad Nicolas Malin added a comment - After a second review I added demo data on example and change the FindExample search to display list with an example of : include-form : ListExamplesWithFeatures include-screen : ListExamplesWithItems include-grid : ListExamplesWithStatus The include-menu is always available on ListCache.
          Hide
          ofbizzer Christian Carlow added a comment -

          Thanks for the help Nicolas.

          Once the grid embedding functionality is committed to the trunk I will attempt to use it to replace the screen at facility/control/ViewContactMechs which is the first one I encountered that required this extension in order to replicate the original FTL.

          Show
          ofbizzer Christian Carlow added a comment - Thanks for the help Nicolas. Once the grid embedding functionality is committed to the trunk I will attempt to use it to replace the screen at facility/control/ViewContactMechs which is the first one I encountered that required this extension in order to replicate the original FTL.
          Hide
          soledad Nicolas Malin added a comment -

          So ... let's run Christian

          done on trunk at revision 1686116

          Show
          soledad Nicolas Malin added a comment - So ... let's run Christian done on trunk at revision 1686116

            People

            • Assignee:
              soledad Nicolas Malin
              Reporter:
              ofbizzer Christian Carlow
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development