Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6438

PartyGeoLocation shows menus when accessed

    Details

    • Sprint:
      Community Day 3 - 2015

      Description

      When viewing the PartyGeoLocation of a party profile, the screen shows the standard set of screens (menus, etc) in stead of just the geo map.

      1. OFBIZ-6438.png
        150 kB
        paveen patil
      2. OFBIZ-6438.patch
        4 kB
        paveen patil

        Activity

        Hide
        pravinpa paveen patil added a comment -

        Attached the patch to resolve the issue.

        Show
        pravinpa paveen patil added a comment - Attached the patch to resolve the issue.
        Hide
        pravinpa paveen patil added a comment -

        Created a new request and screen without any decorator for showing only geo map. the previous used screen contains decorator which causes whole menus to appear in popUp.

        Show
        pravinpa paveen patil added a comment - Created a new request and screen without any decorator for showing only geo map. the previous used screen contains decorator which causes whole menus to appear in popUp.
        Hide
        pfm.smits Pierre Smits added a comment -

        Hi paveen patil,

        I have tested the patch. This works properly, except for the fact that the popup shows the entire menu structure. This shouldn't be so.
        The menu structure is shown, because of the reuse of the geoChart screen in common. Better is it to create a new screen without the trimmings.

        Show
        pfm.smits Pierre Smits added a comment - Hi paveen patil , I have tested the patch. This works properly, except for the fact that the popup shows the entire menu structure. This shouldn't be so. The menu structure is shown, because of the reuse of the geoChart screen in common. Better is it to create a new screen without the trimmings.
        Hide
        pravinpa paveen patil added a comment -

        Hi Pierre,
        Please see the attached screenshot, there is no menus in popup. (Tested on chrome and Firefox)

        Show
        pravinpa paveen patil added a comment - Hi Pierre, Please see the attached screenshot, there is no menus in popup. (Tested on chrome and Firefox)
        Hide
        pfm.smits Pierre Smits added a comment -

        Hi paveen patil,

        You're correct. I accidentally tested it against a local version with change in it. Having tested it against another, it works neat and dandy.

        Thanks.

        Show
        pfm.smits Pierre Smits added a comment - Hi paveen patil , You're correct. I accidentally tested it against a local version with change in it. Having tested it against another, it works neat and dandy. Thanks.
        Hide
        pfm.smits Pierre Smits added a comment -

        Looking at the result, I feel that labels should go below the chart (chart being more import than the data) and the height should be enlarged to 550px (resulting in a square popup and everything shown)..

        Show
        pfm.smits Pierre Smits added a comment - Looking at the result, I feel that labels should go below the chart (chart being more import than the data) and the height should be enlarged to 550px (resulting in a square popup and everything shown)..
        Hide
        pfm.smits Pierre Smits added a comment -

        Can we also change the font type of the popup, so that it is in line with the rest of the site?

        Show
        pfm.smits Pierre Smits added a comment - Can we also change the font type of the popup, so that it is in line with the rest of the site?
        Hide
        diveshdut Divesh Dutta added a comment -

        Reported bug is fixed under in trunk and 14.12 branch in revision. 1703969 and 1703973. Thanks Pravin for the fix and Pierre for reporting the issue.

        Show
        diveshdut Divesh Dutta added a comment - Reported bug is fixed under in trunk and 14.12 branch in revision. 1703969 and 1703973. Thanks Pravin for the fix and Pierre for reporting the issue.
        Hide
        diveshdut Divesh Dutta added a comment -

        For other improvements suggested by Pierre we can have other ticket where we can conclude the improvements and have them in place. As this ticket was focussed on bug, I am closing this ticket.

        Show
        diveshdut Divesh Dutta added a comment - For other improvements suggested by Pierre we can have other ticket where we can conclude the improvements and have them in place. As this ticket was focussed on bug, I am closing this ticket.
        Hide
        pfm.smits Pierre Smits added a comment -

        Which othre ticket are you referring to?

        Show
        pfm.smits Pierre Smits added a comment - Which othre ticket are you referring to?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I guess Divesh means this one is fixed and closed, you should create another one

        Show
        jacques.le.roux Jacques Le Roux added a comment - I guess Divesh means this one is fixed and closed, you should create another one

          People

          • Assignee:
            diveshdut Divesh Dutta
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile