Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6425

FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0

    Details

    1. OFBIZ-6425.patch
      0.6 kB
      Christian Carlow

      Issue Links

        Activity

        Hide
        ofbizzer Christian Carlow added a comment -

        This patch allows the performFindList service to be called by a form widget action without this FTL error occuring (ListProduct was just used for testing):

        Error in form [ListProducts] calling service with name [performFindList]: org.ofbiz.service.GenericServiceException: Outgoing result (in runSync : performFindList) does not match expected requirements (The following required parameter is missing: [performFindList.listSize]))

        Show
        ofbizzer Christian Carlow added a comment - This patch allows the performFindList service to be called by a form widget action without this FTL error occuring (ListProduct was just used for testing): Error in form [ListProducts] calling service with name [performFindList] : org.ofbiz.service.GenericServiceException: Outgoing result (in runSync : performFindList) does not match expected requirements (The following required parameter is missing: [performFindList.listSize] ))
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Sounds like a wise change to me But could you please give more details, like an URL to reproduce the error?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Sounds like a wise change to me But could you please give more details, like an URL to reproduce the error?
        Hide
        ofbizzer Christian Carlow added a comment -

        Hey Jacques,

        I was testing at catalog/control/FindProduct. I just changed ProductForms.xml#ListProducts service-name from performFind to performFindList. Then upon initially visiting the page the error is displayed.

        Show
        ofbizzer Christian Carlow added a comment - Hey Jacques, I was testing at catalog/control/FindProduct. I just changed ProductForms.xml#ListProducts service-name from performFind to performFindList. Then upon initially visiting the page the error is displayed.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        OK, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - OK, thanks!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Christian,

        Your patch is in
        trunk r1710348
        R14.12 r1710350
        R13.07 r1710351
        R12.04 r1710352

        I indeed considered this a bug.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Christian, Your patch is in trunk r1710348 R14.12 r1710350 R13.07 r1710351 R12.04 r1710352 I indeed considered this a bug.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        One question I wonder about though: performFindList is never used in forms only in services. And when you replace performFind by performFindList in the ListProducts form you get no results. Anyway replacing null by 0 for the initial listSize is a good thing.

        Show
        jacques.le.roux Jacques Le Roux added a comment - One question I wonder about though: performFindList is never used in forms only in services. And when you replace performFind by performFindList in the ListProducts form you get no results. Anyway replacing null by 0 for the initial listSize is a good thing.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            ofbizzer Christian Carlow
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development