Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6415

renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox

    Details

    1. OFBIZ-6415.patch
      3 kB
      Christian Carlow

      Activity

      Hide
      ofbizzer Christian Carlow added a comment -

      This patch reselects TextFindField operation dropdown and ignore case checkbox by definine two new methods that reference the context when getting the field. The original values are selected by default.

      Show
      ofbizzer Christian Carlow added a comment - This patch reselects TextFindField operation dropdown and ignore case checkbox by definine two new methods that reference the context when getting the field. The original values are selected by default.
      Hide
      soledad Nicolas Malin added a comment -

      Christian can you give me the reason to test the value name on the parameters and after return de option and not test directly the option ?

      +                if (parameters.containsKey(this.getModelFormField().getName())) {
      +                    defaultOption = (String)parameters.get(this.getModelFormField().getName().concat("_op"));   
      +                }
      
      Show
      soledad Nicolas Malin added a comment - Christian can you give me the reason to test the value name on the parameters and after return de option and not test directly the option ? + if (parameters.containsKey( this .getModelFormField().getName())) { + defaultOption = ( String )parameters.get( this .getModelFormField().getName().concat( "_op" )); + }
      Hide
      ofbizzer Christian Carlow added a comment -

      Hey Nicolas,

      That logic was copied from getIgnoreCase which requires it since it is a checkbox. Since getOption is for drop down, the containsKey can match the get string.

      Show
      ofbizzer Christian Carlow added a comment - Hey Nicolas, That logic was copied from getIgnoreCase which requires it since it is a checkbox. Since getOption is for drop down, the containsKey can match the get string.
      Hide
      soledad Nicolas Malin added a comment -

      I think this code doesn't work with the "Is Empty" option because no value need. I will check that.

      Show
      soledad Nicolas Malin added a comment - I think this code doesn't work with the "Is Empty" option because no value need. I will check that.
      Hide
      ofbizzer Christian Carlow added a comment -

      Hey Nicolas,

      "Is Empty" has been verified as working on my end. I manually updated product.internalName = null and did a search for internalName "Is Empty" at catalog/control/FindProduct and got only that record.

      Show
      ofbizzer Christian Carlow added a comment - Hey Nicolas, "Is Empty" has been verified as working on my end. I manually updated product.internalName = null and did a search for internalName "Is Empty" at catalog/control/FindProduct and got only that record.
      Hide
      soledad Nicolas Malin added a comment -

      You right Christian, I tested and it works fine.

      If resolve as fixed and propage on stable branch because it's also a bug for end user to loose their search options.

      Done on :

      • trunk : 1682342
      • 14.12 : 1682343
      • 13.07 : 1682344
      • 12.04 : 1682345
      Show
      soledad Nicolas Malin added a comment - You right Christian, I tested and it works fine. If resolve as fixed and propage on stable branch because it's also a bug for end user to loose their search options. Done on : trunk : 1682342 14.12 : 1682343 13.07 : 1682344 12.04 : 1682345

        People

        • Assignee:
          soledad Nicolas Malin
          Reporter:
          ofbizzer Christian Carlow
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development