Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6329

Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: content
    • Labels:
      None

      Description

      There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...).

      Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker.

      However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter.

      In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static "true" for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also.

      I will provide a patch for those two issues in the mentioned method.

        Attachments

        1. OFBIZ-6329_Non-Template-Caching-DiffOnly.patch
          1.0 kB
          Martin Becker
        2. OFBIZ-6329_FTL-Caching-DiffOnly.patch
          3 kB
          Martin Becker
        3. OFBIZ-6329_Non-Template-Caching.patch
          1 kB
          Martin Becker
        4. OFBIZ-6329_FTL-Caching.patch
          3 kB
          Martin Becker

          Activity

            People

            • Assignee:
              deepak.dixit Deepak Dixit
              Reporter:
              mbecker Martin Becker
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: