Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2015, Community Day 3 - 2015, Re-Factor Sprint 1

      Description

      ResourceLoader.getXmlRootElement() caches its return value; however, DOM elements are memory intensive, and the returned value tends to only be used once. So, this is a poor pattern.

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Actually I should have thank Adam also!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Actually I should have thank Adam also!
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks for your work on this Deepak!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks for your work on this Deepak!
          Hide
          deepak.dixit Deepak Dixit added a comment -

          This has been merged at r#1731399

          Show
          deepak.dixit Deepak Dixit added a comment - This has been merged at r#1731399
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Can we merge all the fixes from https://svn.apache.org/repos/asf/ofbiz/branches/OFBIZ-6275 into trunk?

          Show
          deepak.dixit Deepak Dixit added a comment - Can we merge all the fixes from https://svn.apache.org/repos/asf/ofbiz/branches/OFBIZ-6275 into trunk?
          Hide
          doogie Adam Heath added a comment -

          Fixed in branch OFBIZ-6275, r1675466

          Show
          doogie Adam Heath added a comment - Fixed in branch OFBIZ-6275 , r1675466
          Hide
          doogie Adam Heath added a comment -

          Same problem, don't use a cached version of this method.

          Show
          doogie Adam Heath added a comment - Same problem, don't use a cached version of this method.
          Hide
          doogie Adam Heath added a comment -

          [javac17] /srv/ofbiz/apache-git/specialpurpose/pos/src/org/ofbiz/pos/config/ButtonEventConfig.java:55: warning: [deprecation] getXmlRootElement(String) in ResourceLoader has been deprecated
          [javac17] Element root = ResourceLoader.getXmlRootElement(ButtonEventConfig.BUTTON_EVENT_CONFIG);
          [javac17] ^

          Show
          doogie Adam Heath added a comment - [javac17] /srv/ofbiz/apache-git/specialpurpose/pos/src/org/ofbiz/pos/config/ButtonEventConfig.java:55: warning: [deprecation] getXmlRootElement(String) in ResourceLoader has been deprecated [javac17] Element root = ResourceLoader.getXmlRootElement(ButtonEventConfig.BUTTON_EVENT_CONFIG); [javac17] ^

            People

            • Assignee:
              deepak.dixit Deepak Dixit
              Reporter:
              doogie Adam Heath
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile