Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6237

function linkGeos deletes existing GeoAssocs for geoId

    Details

    • Sprint:
      Community Day 2 - 2015

      Description

      When creating a new GeoAssoc between a geoId and a geoIdTo all existing GeoAssocs for the geoId are removed. It should however check for existence and add if it doesn't exist.

      1. OFBIZ-6237-1307.patch
        2 kB
        Himanil Gupta
      2. OFBIZ-6237-1412.patch
        2 kB
        Himanil Gupta
      3. OFBIZ-6237-trunk.patch
        2 kB
        Himanil Gupta

        Activity

        Hide
        himanil.gupta Himanil Gupta added a comment -

        As no need of deleting the existing GeoAssoc(s) while creating the new one, so removed the code which deletes the existing GeoAssoc and adding one more check for geoAssocTypeId to filter out the assocs accordingly.

        Attaching patch for the fix of issue for OFBIZ trunk, 13.07 and 14.12 branch.

        Show
        himanil.gupta Himanil Gupta added a comment - As no need of deleting the existing GeoAssoc(s) while creating the new one, so removed the code which deletes the existing GeoAssoc and adding one more check for geoAssocTypeId to filter out the assocs accordingly. Attaching patch for the fix of issue for OFBIZ trunk, 13.07 and 14.12 branch.
        Hide
        arunpati Arun Patidar added a comment -

        Committed patch in trunk at rev: 1686616
        in 14.12 at rev:1686618
        and in 13.07 at rev:1686619

        Thanks Himanil Gupta for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed patch in trunk at rev: 1686616 in 14.12 at rev:1686618 and in 13.07 at rev:1686619 Thanks Himanil Gupta for your contribution.
        Hide
        arunpati Arun Patidar added a comment -

        Hi Jacques,

        This was assigned to you, but I picked and committed the changes. Please have a look and verify the changes. If all looks good then close this ticket else let me know your thoughts.

        Show
        arunpati Arun Patidar added a comment - Hi Jacques, This was assigned to you, but I picked and committed the changes. Please have a look and verify the changes. If all looks good then close this ticket else let me know your thoughts.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I can't remember why I did remove the "old values" at http://svn.apache.org/viewvc?view=revision&revision=1000434. I believe I missed somethning while backporting from a custom project to the jQuery branch. Dor instance the oldGeoIds comes from nowhere in trunk nor in jQuery branch, so it could only be wrong.

        We still miss a way to unlink geos, but that's another issue and I have not enough time, so it's OK with me. I close.

        Show
        jacques.le.roux Jacques Le Roux added a comment - I can't remember why I did remove the "old values" at http://svn.apache.org/viewvc?view=revision&revision=1000434 . I believe I missed somethning while backporting from a custom project to the jQuery branch. Dor instance the oldGeoIds comes from nowhere in trunk nor in jQuery branch, so it could only be wrong. We still miss a way to unlink geos, but that's another issue and I have not enough time, so it's OK with me. I close.
        Hide
        arunpati Arun Patidar added a comment -

        Thank you Jacques.

        Show
        arunpati Arun Patidar added a comment - Thank you Jacques.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        And thank you Arun for taking care of it. I have created OFBIZ-6528 "Add a mean to untie geo associations"

        Show
        jacques.le.roux Jacques Le Roux added a comment - And thank you Arun for taking care of it. I have created OFBIZ-6528 "Add a mean to untie geo associations"

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile