Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6208

rename AccountingConfig.properties to accounting.properties

    Details

      Description

      Currently many properties files in various components are named after the component, i.e. the bi component has bi.properties.

      In order to have consistency from component to component the AccountingConfig.properties file must be renamed to accounting.properties and all references in other components should reflect the change.

      1. OFBIZ-6208-ACCInvoicePerShipmentTests.patch
        2 kB
        Pierre Smits
      2. OFBIZ-6208-ACCInvoiceServices.java.patch
        1 kB
        Pierre Smits
      3. OFBIZ-6208-ACCInvoiceServices.xml.patch
        0.9 kB
        Pierre Smits
      4. OFBIZ-6208-AccountingConfigChange.patch
        5 kB
        Pierre Smits
      5. OFBIZ-6208-ACCPaymentServices.xml.patch
        4 kB
        Pierre Smits
      6. OFBIZ-6208-ORDROrderServices.patch
        0.8 kB
        Pierre Smits
      7. OFBIZ-6208-PRODRentalServices.xml.patch
        1.0 kB
        Pierre Smits

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses the filename change.

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses the filename change.
          Hide
          pfm.smits Pierre Smits added a comment -

          Dependencies on AccountingConfig.properties exist in:

          • order
          • product
          Show
          pfm.smits Pierre Smits added a comment - Dependencies on AccountingConfig.properties exist in: order product
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in InvoiceServices.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in InvoiceServices.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in PaymentServices.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in PaymentServices.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in InvoicePerShipmentTests.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in InvoicePerShipmentTests.xml regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in InvoiceServices.java regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in InvoiceServices.java regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in RentalServices.xml in the product component regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in RentalServices.xml in the product component regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses changed references in OrderServices.java in order component regarding change property filename (AccountingConfig.properties -> accounting.properties).

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses changed references in OrderServices.java in order component regarding change property filename (AccountingConfig.properties -> accounting.properties).
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Dependencies between applications component are fine

          Show
          jacques.le.roux Jacques Le Roux added a comment - Dependencies between applications component are fine
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Pierre, these patches are small, could you please provide rather only 1 patch with all related changes

          Show
          jacques.le.roux Jacques Le Roux added a comment - Pierre, these patches are small, could you please provide rather only 1 patch with all related changes
          Hide
          pfm.smits Pierre Smits added a comment -

          Jacques,

          I will as soon as it has gone through testing.

          Best regards,

          Pierre

          Show
          pfm.smits Pierre Smits added a comment - Jacques, I will as soon as it has gone through testing. Best regards, Pierre
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Testing: you mean on our side or your? I guess it's ours, you should have done testing on your side before submittint patches. Then look, several files mean several downloads and several applies, see my point? It's not specifically for this case but by and large...

          Thanks for your work!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Testing: you mean on our side or your? I guess it's ours, you should have done testing on your side before submittint patches. Then look, several files mean several downloads and several applies, see my point? It's not specifically for this case but by and large... Thanks for your work!
          Hide
          pfm.smits Pierre Smits added a comment -

          It is work in progress.

          Show
          pfm.smits Pierre Smits added a comment - It is work in progress.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Better to not submit patches then, or say it

          Show
          jacques.le.roux Jacques Le Roux added a comment - Better to not submit patches then, or say it
          Hide
          pfm.smits Pierre Smits added a comment -

          It is stated.

          Show
          pfm.smits Pierre Smits added a comment - It is stated.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Pierre, did you get a chance?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Pierre, did you get a chance?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Still a WIP or should we review and hopefully commit?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Still a WIP or should we review and hopefully commit?
          Hide
          pfm.smits Pierre Smits added a comment -

          Thanks for the reminder, Jacques. Yes, the status of the issue hasn't changed. So it is safe to assume that it still is.

          Of course, you can always review it yourself and share your findings. If you then, based on that, want to change the status of the issue, you are free to do so. I don't determine what is committable or not.

          Best regards,

          Pierre

          Show
          pfm.smits Pierre Smits added a comment - Thanks for the reminder, Jacques. Yes, the status of the issue hasn't changed. So it is safe to assume that it still is. Of course, you can always review it yourself and share your findings. If you then, based on that, want to change the status of the issue, you are free to do so. I don't determine what is committable or not. Best regards, Pierre
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Pierre,

          Your patches are in trunk at revision: 1736734

          I also changed a bunch of accountingconfig names in comments/descriptions/etc. to "accounting config"

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your patches are in trunk at revision: 1736734 I also changed a bunch of accountingconfig names in comments/descriptions/etc. to "accounting config"

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              pfm.smits Pierre Smits
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development