Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6082

HELP_HR_Main.xml invalid Docbook syntax

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: humanres
    • Labels:
      None
    • Environment:

      All

    • Sprint:
      Sharan - Jira Test Sprint, Bug Crush Event - 21/2/2015

      Description

      Titles can only be used once in a section.
      Add sub-sctions to HELP_HR_Main.xml

        Activity

        Hide
        ronatartifact Ron Wheeler added a comment -

        Index: applications/humanres/data/helpdata/HELP_HR_main.xml
        ===================================================================
        — applications/humanres/data/helpdata/HELP_HR_main.xml (revision 1659295)
        +++ applications/humanres/data/helpdata/HELP_HR_main.xml (working copy)
        @@ -33,8 +33,8 @@
        as a "Group member". </para>

        <para>The number of organizational levels can be as many as required.</para>

        • <title> Nodes In the Company Tree</title>
          +<section>
          + <title> Nodes In the Company Tree</title>

        <para>There are three node types in the tree, each identified by a
        different icon. The top of the tree represents your Company, the highest
        @@ -41,14 +41,15 @@
        level in the organization. The Company and departments under the
        Company can have sub departments or positions. Under positions are
        the people who fulfill the position.</para>

        • <title>Usage</title>
          + </section>
          + <section>
          + <title>Usage</title>
        • <itemizedlist>
          + <itemizedlist>
          <listitem>
          <para>Navigate the organization to view departments, positions and
          people</para>
        • </listitem>
          + </listitem>

        <listitem>
        <para>Add or remove a department</para>
        @@ -67,5 +68,5 @@
        position</para>
        </listitem>
        </itemizedlist>

        • + </section>
          </section>

        Show
        ronatartifact Ron Wheeler added a comment - Index: applications/humanres/data/helpdata/HELP_HR_main.xml =================================================================== — applications/humanres/data/helpdata/HELP_HR_main.xml (revision 1659295) +++ applications/humanres/data/helpdata/HELP_HR_main.xml (working copy) @@ -33,8 +33,8 @@ as a "Group member". </para> <para>The number of organizational levels can be as many as required.</para> <title> Nodes In the Company Tree</title> +<section> + <title> Nodes In the Company Tree</title> <para>There are three node types in the tree, each identified by a different icon. The top of the tree represents your Company, the highest @@ -41,14 +41,15 @@ level in the organization. The Company and departments under the Company can have sub departments or positions. Under positions are the people who fulfill the position.</para> <title>Usage</title> + </section> + <section> + <title>Usage</title> <itemizedlist> + <itemizedlist> <listitem> <para>Navigate the organization to view departments, positions and people</para> </listitem> + </listitem> <listitem> <para>Add or remove a department</para> @@ -67,5 +68,5 @@ position</para> </listitem> </itemizedlist> + </section> </section>
        Hide
        sharan Sharan Foga added a comment -

        Thanks for picking this up Ron. I'll assign it to myself to sort out.

        One of the things I came across moving the HR documentation over was that not all the Docbook tags seems to be supported in our implementation (e.g chapter, sect1, sect2 etc) so I've had to convert all of them to section which is where I think this error crept in.

        Show
        sharan Sharan Foga added a comment - Thanks for picking this up Ron. I'll assign it to myself to sort out. One of the things I came across moving the HR documentation over was that not all the Docbook tags seems to be supported in our implementation (e.g chapter, sect1, sect2 etc) so I've had to convert all of them to section which is where I think this error crept in.
        Hide
        sharan Sharan Foga added a comment -

        HI Ron - you flagged this as 'Patch Available' but I can't see any attachment. Please can you attach the patch file. Thanks

        Show
        sharan Sharan Foga added a comment - HI Ron - you flagged this as 'Patch Available' but I can't see any attachment. Please can you attach the patch file. Thanks
        Hide
        ronaldmwheeler Ronald Wheeler added a comment -

        It is in the comments.


        Ron Wheeler
        President
        Artifact Software Inc
        email: rwheeler@artifact-software.com
        skype: ronaldmwheeler
        phone: 866-970-2435, ext 102

        Show
        ronaldmwheeler Ronald Wheeler added a comment - It is in the comments. – Ron Wheeler President Artifact Software Inc email: rwheeler@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
        Hide
        sharan Sharan Foga added a comment -

        Hi Ron

        In future please can you attach a patch file as recommended in the guidelines as it makes testing and implementing the patch quicker and easier. Adding the actual code in the comments causes additional work as it needs to be manually copied or read both of which can introduce potential errors. It can also cause confusion if errors are found during testing and the patch needs to be updated for another one.

        As this is a small change so I'll do it manually this time.

        Thanks
        Sharan

        Show
        sharan Sharan Foga added a comment - Hi Ron In future please can you attach a patch file as recommended in the guidelines as it makes testing and implementing the patch quicker and easier. Adding the actual code in the comments causes additional work as it needs to be manually copied or read both of which can introduce potential errors. It can also cause confusion if errors are found during testing and the patch needs to be updated for another one. As this is a small change so I'll do it manually this time. Thanks Sharan
        Hide
        sharan Sharan Foga added a comment -

        Thanks Ron - Fix applied

        Trunk : r1661303
        R14.12: r1661304

        Show
        sharan Sharan Foga added a comment - Thanks Ron - Fix applied Trunk : r1661303 R14.12: r1661304
        Hide
        sharan Sharan Foga added a comment -

        Patch applied

        Show
        sharan Sharan Foga added a comment - Patch applied

          People

          • Assignee:
            sharan Sharan Foga
            Reporter:
            ronatartifact Ron Wheeler
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile