Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5854

Order On Hold Auto Approves When Edited

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.02
    • Component/s: order
    • Labels:
      None

      Description

      If you put an approved order on hold and then later cancel an item on the order, the order is auto approved. Order must have two line items to test the behavior. The expected result is that order should stay on hold.

      In this chain of events, following eca is triggered. The service 'checkOrderItemStatus' should be fixed such that it also check the current order header status before it approve the order.

          <eca service="changeOrderItemStatus" event="commit">
              <condition field-name="statusId" operator="equals" value="ITEM_CANCELLED"/>
              <action service="cancelOrderInventoryReservation" mode="sync"/>
              <action service="recalcTaxTotal" mode="sync"/>
              <action service="resetGrandTotal" mode="sync"/>
              <action service="checkOrderItemStatus" mode="sync"/>
          </eca>
      
      1. order.patch
        0.7 kB
        Vikas Mayur

        Activity

        Hide
        akashjain2010 Akash Jain added a comment -

        Verified with attached patch over trunk and 13.07 branch. It is working as expected.

        Following are the steps:

        1. Go to order detail page of any order which have Hold status and multiple order items.
        2. Edit order by pressing Edit Items button and cancel any order item.

        Expected Result: Order status should not be changed if any non cancelled order item available.

        Show
        akashjain2010 Akash Jain added a comment - Verified with attached patch over trunk and 13.07 branch. It is working as expected. Following are the steps: Go to order detail page of any order which have Hold status and multiple order items. Edit order by pressing Edit Items button and cancel any order item. Expected Result: Order status should not be changed if any non cancelled order item available.
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Vikas for creating the issue. Thanks Akash for the verification.
        Committed the changes in trunk at r1639833 and in RB13.07 at r1639834.

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Vikas for creating the issue. Thanks Akash for the verification. Committed the changes in trunk at r1639833 and in RB13.07 at r1639834.

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            vikasmayur Vikas Mayur
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development