Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5709

ProductionRun doesn't capture and show manufacturing organisation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
    • Fix Version/s: 16.11.01
    • Component/s: manufacturing
    • Labels:
      None
    • Sprint:
      Sharan - Jira Test Sprint

      Description

      The production run should capture the manufacturing (internal) organisation on creation.
      But it doesn't.

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment -

          This is important when having multiple internal manufacturing organisations and for G.R.C. with respect of product liability.

          Show
          pfm.smits Pierre Smits added a comment - This is important when having multiple internal manufacturing organisations and for G.R.C. with respect of product liability.
          Hide
          pfm.smits Pierre Smits added a comment -

          It should take the parties from following settings:

          • from the production schema (when available) for production run level
          • from the associated tasks in the schema (when available) for the production run tasks
          • from the product (when available) for production run level (regarding the manufacturing organisation)
          • from creating party (role: production manager) for production run level
          • from the associated organisation party for the role of the manufacturing organisation, for production run level
          • from the default internal organisation for the role of the manufacturing organisation, for production run level
          Show
          pfm.smits Pierre Smits added a comment - It should take the parties from following settings: from the production schema (when available) for production run level from the associated tasks in the schema (when available) for the production run tasks from the product (when available) for production run level (regarding the manufacturing organisation) from creating party (role: production manager) for production run level from the associated organisation party for the role of the manufacturing organisation, for production run level from the default internal organisation for the role of the manufacturing organisation, for production run level
          Hide
          diveshdut Divesh Dutta added a comment -

          Similar to OFBiz-5705 and OFBiz-5706 , this issue can also be marked as an improvement

          Show
          diveshdut Divesh Dutta added a comment - Similar to OFBiz-5705 and OFBiz-5706 , this issue can also be marked as an improvement
          Hide
          pfm.smits Pierre Smits added a comment -

          Thanks for the assessment, Divesh. Changed accordingly.

          Show
          pfm.smits Pierre Smits added a comment - Thanks for the assessment, Divesh. Changed accordingly.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Thanks Pierre for reporting the limitation.
          Thanks Divesh for looking into the details, it should be worked out as an improvement as initial modeling didn't take these things into consideration.

          Show
          pandeypranay Pranay Pandey added a comment - Thanks Pierre for reporting the limitation. Thanks Divesh for looking into the details, it should be worked out as an improvement as initial modeling didn't take these things into consideration.
          Hide
          pfm.smits Pierre Smits added a comment -

          The patch for this issue is included in OFBIZ-5706

          Show
          pfm.smits Pierre Smits added a comment - The patch for this issue is included in OFBIZ-5706
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Pierre,

          Your patch is in trunk at revision: 1659914 (relates to OFBIZ-5706)

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your patch is in trunk at revision: 1659914 (relates to OFBIZ-5706 )
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks to Deepak's report on dev ML:

          > + manufacturer = from("WorkEffortPartyAssignment").where("workEffortId", productionRunId, "roleTypeId", "MANUFACTURER").queryOne();
          Here we need to use filterByDate for “ WorkEffortPartyAssignment”.

          I have committed a fix at r1661323

          Actually it was a bit more because WorkEffortPartyAssignment PK is
          <prim-key field="workEffortId"/>
          <prim-key field="partyId"/>
          <prim-key field="roleTypeId"/>
          <prim-key field="fromDate"/>

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks to Deepak's report on dev ML: > + manufacturer = from("WorkEffortPartyAssignment").where("workEffortId", productionRunId, "roleTypeId", "MANUFACTURER").queryOne(); Here we need to use filterByDate for “ WorkEffortPartyAssignment”. I have committed a fix at r1661323 Actually it was a bit more because WorkEffortPartyAssignment PK is <prim-key field="workEffortId"/> <prim-key field="partyId"/> <prim-key field="roleTypeId"/> <prim-key field="fromDate"/>

            People

            • Assignee:
              pfm.smits Pierre Smits
              Reporter:
              pfm.smits Pierre Smits
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile