OFBiz
  1. OFBiz
  2. OFBIZ-563

Entity Model Reader needs reserved word check

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      Entity Engine needs to check if alias for member enttity is a reserved word. If someone could point me in the direction of a comprehensive list for most databases, I would be happy to look into implementing this. Would this be better to simply throw an error or to append the reserved word with nonsensical letters? Is there actual usage (or could there be actual usage) of the member entity's defined alias outside of the scope of the entity engine?

        Activity

        Hide
        David E. Jones added a comment -

        The current entity checking code, including the reserved word list and checking it, is in the ModelEntityChecker.java file. I don't think it does a reserved word check on the view-entity -> member-entity -> entity-alias attribute right now, so that would be great to add.

        Show
        David E. Jones added a comment - The current entity checking code, including the reserved word list and checking it, is in the ModelEntityChecker.java file. I don't think it does a reserved word check on the view-entity -> member-entity -> entity-alias attribute right now, so that would be great to add.
        Hide
        Adam Heath added a comment -

        Actually, instead of disallowing various aliases, it should map all aliases in a view definition to an internal token, that way it wouldn't matter what alias name is used.

        Show
        Adam Heath added a comment - Actually, instead of disallowing various aliases, it should map all aliases in a view definition to an internal token, that way it wouldn't matter what alias name is used.

          People

          • Assignee:
            Adam Heath
            Reporter:
            Chris Howe
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development