OFBiz
  1. OFBiz
  2. OFBIZ-552

Integration Shark 1.1_2 into OfBiz

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:
      None
    1. versioned_shark_jars.zip
      2.47 MB
      Sergey Shutov
    2. shark.patch
      7 kB
      Jacques Le Roux
    3. shark_2~tabs.diff
      312 kB
      Jacques Le Roux
    4. shark_2.diff
      301 kB
      Sergey Shutov
    5. shark_2.diff
      21 kB
      Sergey Shutov
    6. shark_2.diff
      19 kB
      Jacques Le Roux
    7. shark_2.diff
      27 kB
      Sergey Shutov
    8. example.xpdl
      42 kB
      Jacques Le Roux
    9. EntityPersistentMgr.java.patch
      10 kB
      Jacques Le Roux

      Activity

      Hide
      Jacques Le Roux added a comment -

      Adam fixed it at r884347. I do not backport to R9.04

      Show
      Jacques Le Roux added a comment - Adam fixed it at r884347. I do not backport to R9.04
      Hide
      Jacques Le Roux added a comment -

      I will soon add a patch from my current WIP trying to compile Shark

      Show
      Jacques Le Roux added a comment - I will soon add a patch from my current WIP trying to compile Shark
      Hide
      Jacques Le Roux added a comment -

      I applied the last patch in trunk revision: 664048 and release4.0 664052.

      In the patch there was some uilabels.properties files. I commited them all and removed after the Italian one since its labels were already in SharkUILabels.xml (but I have no ideas how this is possible, maybe Marco did it by hand ?). The labels of SharkUiLabels_ru.properties are not integrated in SharkUILabels.xml that why I let the file in.

      Show
      Jacques Le Roux added a comment - I applied the last patch in trunk revision: 664048 and release4.0 664052. In the patch there was some uilabels.properties files. I commited them all and removed after the Italian one since its labels were already in SharkUILabels.xml (but I have no ideas how this is possible, maybe Marco did it by hand ?). The labels of SharkUiLabels_ru.properties are not integrated in SharkUILabels.xml that why I let the file in.
      Hide
      Jacques Le Roux added a comment -

      Hi Jacopo,

      I don't remember clearly. Much have been done and commited. I think I did stop for commit rights change reason. I will have a look.

      Show
      Jacques Le Roux added a comment - Hi Jacopo, I don't remember clearly. Much have been done and commited. I think I did stop for commit rights change reason. I will have a look.
      Hide
      Jacopo Cappellato added a comment -

      What is the current status of this issue?

      Show
      Jacopo Cappellato added a comment - What is the current status of this issue?
      Hide
      Jacques Le Roux added a comment -

      After a clean and a rebuild with last scn (rev. 524830) I had to change the exception from GenericServiceException to Exception in the try catch block in SharkContainer.java[111] to compile. I did not understand why though, nor searched more.

      Show
      Jacques Le Roux added a comment - After a clean and a rebuild with last scn (rev. 524830) I had to change the exception from GenericServiceException to Exception in the try catch block in SharkContainer.java [111] to compile. I did not understand why though, nor searched more.
      Hide
      Jacques Le Roux added a comment -

      For commiters,

      Please note Eriks's remarks about UiLabels files names.

      Show
      Jacques Le Roux added a comment - For commiters, Please note Eriks's remarks about UiLabels files names.
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Because of new commiters policy I have no more write access to the framework branch. Nevertheless, I did a quick review of your last patch (shark_2.diff). I deleted mods that were enabling Shark in OFBiz and made some formatting (no tabs please). I did no test the patch but from my POV it seems clean.

      Show
      Jacques Le Roux added a comment - Sergey, Because of new commiters policy I have no more write access to the framework branch. Nevertheless, I did a quick review of your last patch (shark_2.diff). I deleted mods that were enabling Shark in OFBiz and made some formatting (no tabs please). I did no test the patch but from my POV it seems clean.
      Hide
      Sergey Shutov added a comment -

      I have added following new features:
      1) tnamesrv automaticaly startup and shut down;
      2) data type changed from BIGINT to NUMERIC(19,0) with the "long" name, also it is added in all configuration files;

      Show
      Sergey Shutov added a comment - I have added following new features: 1) tnamesrv automaticaly startup and shut down; 2) data type changed from BIGINT to NUMERIC(19,0) with the "long" name, also it is added in all configuration files;
      Hide
      Eriks Dobelis added a comment -

      Changing of long to numeric didn't work for Postgres, as by default it is limited to 18 digits, but Shark was creating longer numbers. So, to make it run with Postgres I had to add entry long with sql-type BIGINT to fieldtypepostgres.xml

      Also, I keep getting entries like these a lot:
      2007-03-06 15:37:39,314 (TP-Processor1) [StandardLoggingManager.java:135:WARN ] Can't create external requester - org.ofbiz.shark.requester.LoggingRequester is not in the classpath, or it doesn't have default constructor.
      2007-03-06 15:37:39,317 (TP-Processor1) [StandardLoggingManager.java:135:WARN ] Can't create external requester - org.ofbiz.shark.requester.SimpleRequester is not in the classpath, or it doesn't have default constructor.

      Sergey, could you comment this, please?

      Show
      Eriks Dobelis added a comment - Changing of long to numeric didn't work for Postgres, as by default it is limited to 18 digits, but Shark was creating longer numbers. So, to make it run with Postgres I had to add entry long with sql-type BIGINT to fieldtypepostgres.xml Also, I keep getting entries like these a lot: 2007-03-06 15:37:39,314 (TP-Processor1) [StandardLoggingManager.java:135:WARN ] Can't create external requester - org.ofbiz.shark.requester.LoggingRequester is not in the classpath, or it doesn't have default constructor. 2007-03-06 15:37:39,317 (TP-Processor1) [StandardLoggingManager.java:135:WARN ] Can't create external requester - org.ofbiz.shark.requester.SimpleRequester is not in the classpath, or it doesn't have default constructor. Sergey, could you comment this, please?
      Hide
      Eriks Dobelis added a comment -

      I tried to run Shark in OFBiz and there were at least two problems:

      1) in entitymodel.xml there are fields of type "long", such type is defined only for Derby databases in filetype file, so I had to replace all those with numeric to work with Postgres;
      2) filename of Ui properties file should be SharkUiLabels.properties instead of SharkUILabels.properties.

      Show
      Eriks Dobelis added a comment - I tried to run Shark in OFBiz and there were at least two problems: 1) in entitymodel.xml there are fields of type "long", such type is defined only for Derby databases in filetype file, so I had to replace all those with numeric to work with Postgres; 2) filename of Ui properties file should be SharkUiLabels.properties instead of SharkUILabels.properties.
      Hide
      Jacques Le Roux added a comment -

      Eriks,

      Due to licence constraint (Shark is GPL) I doubt that Shark will never be offically integrated in OFBiz. Please read OPTIONNAL_LIBRAIRIES. So c) seems more appropriate.

      Show
      Jacques Le Roux added a comment - Eriks, Due to licence constraint (Shark is GPL) I doubt that Shark will never be offically integrated in OFBiz. Please read OPTIONNAL_LIBRAIRIES. So c) seems more appropriate.
      Hide
      Sergey Shutov added a comment -

      I have JavaDoc 1.2 release on my PC. I can upload zip archive into JIRA.

      Show
      Sergey Shutov added a comment - I have JavaDoc 1.2 release on my PC. I can upload zip archive into JIRA.
      Hide
      Sergey Shutov added a comment -

      I have some operating time for integration Shark 2 public version into
      OfBiz.

      Show
      Sergey Shutov added a comment - I have some operating time for integration Shark 2 public version into OfBiz.
      Show
      Jacques Le Roux added a comment - You may try this request too : http://www.nabble.com/forum/Search.jtp?forum=2478&local=y&query=1.1-2+source
      Hide
      Jacques Le Roux added a comment -

      Hi Al,

      I'm afraid this is anymore available. You may try to ask for from this thread : http://mail-archive.objectweb.org/shark/2006-05/msg00089.html

      Show
      Jacques Le Roux added a comment - Hi Al, I'm afraid this is anymore available. You may try to ask for from this thread : http://mail-archive.objectweb.org/shark/2006-05/msg00089.html
      Hide
      Eriks Dobelis added a comment -

      Thanks, Sergey and Jacques - this is great that we have Shark integrated!

      What do we generally do with this next? Will we a) consider creating new OFBiz applications/services which use Shark, b) consider changes in existing applications to use Shark or c) generally leave Shark usage possibility only as a choice for those who want/need it, but not use it in OFBiz code?

      Show
      Eriks Dobelis added a comment - Thanks, Sergey and Jacques - this is great that we have Shark integrated! What do we generally do with this next? Will we a) consider creating new OFBiz applications/services which use Shark, b) consider changes in existing applications to use Shark or c) generally leave Shark usage possibility only as a choice for those who want/need it, but not use it in OFBiz code?
      Hide
      Al Byers added a comment -

      Sergey,

      This certainly is a great addition to OFBiz. Thanks.

      I was wondering if you could point me to a site where I could get the source (or at least the javadocs) for Shark version 1.2?

      -Al Byers

      Show
      Al Byers added a comment - Sergey, This certainly is a great addition to OFBiz. Thanks. I was wondering if you could point me to a site where I could get the source (or at least the javadocs) for Shark version 1.2? -Al Byers
      Hide
      Sergey Shutov added a comment -

      No problem, I will change it.

      Show
      Sergey Shutov added a comment - No problem, I will change it.
      Hide
      Jacques Le Roux added a comment -

      Mmm... too fast, too tired.. It seems that we shall better use
      <field-type-def type="numeric" sql-type="NUMERIC(18,0)" java-type="Long"><validate method="isSignedLong" /></field-type-def>
      in place of
      <field-type-def type="long" sql-type="BIGINT" java-type="java.lang.Long"></field-type-def>
      added by Sergey. I see 2 advantages : validate method="isSignedLong and no redundancy. Am I missing something here ?

      Show
      Jacques Le Roux added a comment - Mmm... too fast, too tired.. It seems that we shall better use <field-type-def type="numeric" sql-type="NUMERIC(18,0)" java-type="Long"><validate method="isSignedLong" /></field-type-def> in place of <field-type-def type="long" sql-type="BIGINT" java-type="java.lang.Long"></field-type-def> added by Sergey. I see 2 advantages : validate method="isSignedLong and no redundancy. Am I missing something here ?
      Hide
      Jacques Le Roux added a comment -

      OK, it works well with (sorry) framework/shark/example/ofb_test.xpdl :/

      Another point, at first I did not notice (or rather I said to myslef : later) that Sergey added a type BIGINT in fieldtypederby.xml :
      <field-type-def type="long" sql-type="BIGINT" java-type="java.lang.Long"></field-type-def>
      I checked I guess it's needed : there are no unsigned long already. I will put this new type in other fieltype*.xml files.

      Show
      Jacques Le Roux added a comment - OK, it works well with (sorry) framework/shark/example/ofb_test.xpdl :/ Another point, at first I did not notice (or rather I said to myslef : later) that Sergey added a type BIGINT in fieldtypederby.xml : <field-type-def type="long" sql-type="BIGINT" java-type="java.lang.Long"></field-type-def> I checked I guess it's needed : there are no unsigned long already. I will put this new type in other fieltype*.xml files.
      Hide
      Jacques Le Roux added a comment -

      Just to let know the community. I sent a letter to Sergey and his reponse was

      > Hello!
      > My degree work is the best in my institute group!!!

      Congratulations Sergey !

      We will be happy to see you among us in future.

      Wish you success for the rest.

      Jacques

      BTW I tried with another XPLD file : https://wiki.objectweb.org/shark/attach?page=Vh1%2Fapgar-v03-perinatal-care.xpdl, same problem. Anybody having a file that load please, thanks ?

      Show
      Jacques Le Roux added a comment - Just to let know the community. I sent a letter to Sergey and his reponse was > Hello! > My degree work is the best in my institute group!!! Congratulations Sergey ! We will be happy to see you among us in future. Wish you success for the rest. Jacques BTW I tried with another XPLD file : https://wiki.objectweb.org/shark/attach?page=Vh1%2Fapgar-v03-perinatal-care.xpdl , same problem. Anybody having a file that load please, thanks ?
      Hide
      Sergey Shutov added a comment -

      Yes, please I very need this!!

      1) Importance of Shark integration into OfBiz.
      2) The role of the Shark in OfBiz.
      3) Degree of knowledge from architecture Shark and OfBiz
      4) What my level of culture of programming.
      5) Quality of the completed integration.

      Show
      Sergey Shutov added a comment - Yes, please I very need this!! 1) Importance of Shark integration into OfBiz. 2) The role of the Shark in OfBiz. 3) Degree of knowledge from architecture Shark and OfBiz 4) What my level of culture of programming. 5) Quality of the completed integration.
      Hide
      Jacques Le Roux added a comment -

      Hi Sergey,

      Thanks so this is not a problem we shall use last Sun 1.5 SDK (strange for 1.6 but it's a RC forget it). Thanks fot the tip too. I agree to write you a letter if needed but what to you need exactly. BTW I did not receive any message with an attachment (I checked my SpamCop trash container) nor a message about your degree work.

      Show
      Jacques Le Roux added a comment - Hi Sergey, Thanks so this is not a problem we shall use last Sun 1.5 SDK (strange for 1.6 but it's a RC forget it). Thanks fot the tip too. I agree to write you a letter if needed but what to you need exactly. BTW I did not receive any message with an attachment (I checked my SpamCop trash container) nor a message about your degree work.
      Hide
      Sergey Shutov added a comment -

      Yes I know about this issue in 1.5.0_05 or *_06.
      But, I used sun sdk 1.5.0_09 and 1.5.0_10, I could not reproduce this
      warning.

      You can try to add the following line to the startofbiz.bat befor OfBiz
      starting.
      start "Name Server" "%JAVA_HOME%\bin\tnameserv" -ORBInitialPort 2000

      PS.
      Do you receive message about my degree work?

      Show
      Sergey Shutov added a comment - Yes I know about this issue in 1.5.0_05 or *_06. But, I used sun sdk 1.5.0_09 and 1.5.0_10, I could not reproduce this warning. You can try to add the following line to the startofbiz.bat befor OfBiz starting. start "Name Server" "%JAVA_HOME%\bin\tnameserv" -ORBInitialPort 2000 PS. Do you receive message about my degree work?
      Hide
      Sergey Shutov added a comment -

      Thanks!

      Show
      Sergey Shutov added a comment - Thanks!
      Hide
      Sergey Shutov added a comment -

      I don't know.

      May be the WfMC standard has been changed from Shark version 1.2_1. I will
      be checking it.

      Sorry, but I shall be defending the diploma project in 3 days.
      I have no time for a work with a Shark.

      PS
      Can you write the official letter for me about my work? I would attach it in
      my degree project.

      Show
      Sergey Shutov added a comment - I don't know. May be the WfMC standard has been changed from Shark version 1.2_1. I will be checking it. Sorry, but I shall be defending the diploma project in 3 days. I have no time for a work with a Shark. PS Can you write the official letter for me about my work? I would attach it in my degree project.
      Hide
      Jacques Le Roux added a comment -

      Using SDK 1.5.0_07 I get this warning (also with 1.6.0-rc). No problem with 1.4.2_05. It refers to a Sun known bug (Sun claims it is fixed from 1. 5.0u6(b01) but I'm not sure as it's always there in 1.6.0-rc) : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5068014.

      Jan 22, 2007 3:32:53 PM com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl <init>
      WARNING: "IOP00410201: (COMM_FAILURE) Connection failure: socketType: IIOP_CLEAR_TEXT; hostname: 127.0.0.1; port: 2000"
      org.omg.CORBA.COMM_FAILURE: vmcid: SUN minor code: 201 completed: No
      at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2172)
      at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2193)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:205)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:218)
      at com.sun.corba.se.impl.transport.SocketOrChannelContactInfoImpl.createConnection(SocketOrChannelContactInfoImpl.java:101)
      at com.sun.corba.se.impl.protocol.CorbaClientRequestDispatcherImpl.beginRequest(CorbaClientRequestDispatcherImpl.java:152)
      at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.request(CorbaClientDelegateImpl.java:118)
      at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.is_a(CorbaClientDelegateImpl.java:211)
      at org.omg.CORBA.portable.ObjectImpl._is_a(ObjectImpl.java:112)
      at org.omg.CosNaming.NamingContextHelper.narrow(NamingContextHelper.java:69)
      at org.enhydra.shark.corba.poa.SharkCORBAServer.startCORBAServer(SharkCORBAServer.java:169)
      at org.ofbiz.shark.container.SharkContainer.run(SharkContainer.java:183)
      at java.lang.Thread.run(Thread.java:595)
      Caused by: java.net.ConnectException: Connection refused: connect
      at sun.nio.ch.Net.connect(Native Method)
      at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:464)
      at java.nio.channels.SocketChannel.open(SocketChannel.java:146)
      at com.sun.corba.se.impl.transport.DefaultSocketFactoryImpl.createSocket(DefaultSocketFactoryImpl.java:60)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:188)
      ... 10 more
      Exception in thread "org.ofbiz.shark.container.SharkContainer" org.omg.CORBA.COMM_FAILURE: vmcid: SUN minor code: 201 completed: No
      at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2172)
      at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2193)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:205)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:218)
      at com.sun.corba.se.impl.transport.SocketOrChannelContactInfoImpl.createConnection(SocketOrChannelContactInfoImpl.java:101)
      at com.sun.corba.se.impl.protocol.CorbaClientRequestDispatcherImpl.beginRequest(CorbaClientRequestDispatcherImpl.java:152)
      at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.request(CorbaClientDelegateImpl.java:118)
      at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.is_a(CorbaClientDelegateImpl.java:211)
      at org.omg.CORBA.portable.ObjectImpl._is_a(ObjectImpl.java:112)
      at org.omg.CosNaming.NamingContextHelper.narrow(NamingContextHelper.java:69)
      at org.enhydra.shark.corba.poa.SharkCORBAServer.startCORBAServer(SharkCORBAServer.java:169)
      at org.ofbiz.shark.container.SharkContainer.run(SharkContainer.java:183)
      at java.lang.Thread.run(Thread.java:595)
      Caused by: java.net.ConnectException: Connection refused: connect
      at sun.nio.ch.Net.connect(Native Method)
      at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:464)
      at java.nio.channels.SocketChannel.open(SocketChannel.java:146)
      at com.sun.corba.se.impl.transport.DefaultSocketFactoryImpl.createSocket(DefaultSocketFactoryImpl.java:60)
      at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:188)
      ... 10 more

      Show
      Jacques Le Roux added a comment - Using SDK 1.5.0_07 I get this warning (also with 1.6.0-rc). No problem with 1.4.2_05. It refers to a Sun known bug (Sun claims it is fixed from 1. 5.0u6(b01) but I'm not sure as it's always there in 1.6.0-rc) : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5068014 . Jan 22, 2007 3:32:53 PM com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl <init> WARNING: "IOP00410201: (COMM_FAILURE) Connection failure: socketType: IIOP_CLEAR_TEXT; hostname: 127.0.0.1; port: 2000" org.omg.CORBA.COMM_FAILURE: vmcid: SUN minor code: 201 completed: No at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2172) at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2193) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:205) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:218) at com.sun.corba.se.impl.transport.SocketOrChannelContactInfoImpl.createConnection(SocketOrChannelContactInfoImpl.java:101) at com.sun.corba.se.impl.protocol.CorbaClientRequestDispatcherImpl.beginRequest(CorbaClientRequestDispatcherImpl.java:152) at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.request(CorbaClientDelegateImpl.java:118) at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.is_a(CorbaClientDelegateImpl.java:211) at org.omg.CORBA.portable.ObjectImpl._is_a(ObjectImpl.java:112) at org.omg.CosNaming.NamingContextHelper.narrow(NamingContextHelper.java:69) at org.enhydra.shark.corba.poa.SharkCORBAServer.startCORBAServer(SharkCORBAServer.java:169) at org.ofbiz.shark.container.SharkContainer.run(SharkContainer.java:183) at java.lang.Thread.run(Thread.java:595) Caused by: java.net.ConnectException: Connection refused: connect at sun.nio.ch.Net.connect(Native Method) at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:464) at java.nio.channels.SocketChannel.open(SocketChannel.java:146) at com.sun.corba.se.impl.transport.DefaultSocketFactoryImpl.createSocket(DefaultSocketFactoryImpl.java:60) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:188) ... 10 more Exception in thread "org.ofbiz.shark.container.SharkContainer" org.omg.CORBA.COMM_FAILURE: vmcid: SUN minor code: 201 completed: No at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2172) at com.sun.corba.se.impl.logging.ORBUtilSystemException.connectFailure(ORBUtilSystemException.java:2193) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:205) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:218) at com.sun.corba.se.impl.transport.SocketOrChannelContactInfoImpl.createConnection(SocketOrChannelContactInfoImpl.java:101) at com.sun.corba.se.impl.protocol.CorbaClientRequestDispatcherImpl.beginRequest(CorbaClientRequestDispatcherImpl.java:152) at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.request(CorbaClientDelegateImpl.java:118) at com.sun.corba.se.impl.protocol.CorbaClientDelegateImpl.is_a(CorbaClientDelegateImpl.java:211) at org.omg.CORBA.portable.ObjectImpl._is_a(ObjectImpl.java:112) at org.omg.CosNaming.NamingContextHelper.narrow(NamingContextHelper.java:69) at org.enhydra.shark.corba.poa.SharkCORBAServer.startCORBAServer(SharkCORBAServer.java:169) at org.ofbiz.shark.container.SharkContainer.run(SharkContainer.java:183) at java.lang.Thread.run(Thread.java:595) Caused by: java.net.ConnectException: Connection refused: connect at sun.nio.ch.Net.connect(Native Method) at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:464) at java.nio.channels.SocketChannel.open(SocketChannel.java:146) at com.sun.corba.se.impl.transport.DefaultSocketFactoryImpl.createSocket(DefaultSocketFactoryImpl.java:60) at com.sun.corba.se.impl.transport.SocketOrChannelConnectionImpl.<init>(SocketOrChannelConnectionImpl.java:188) ... 10 more
      Hide
      Sergey Shutov added a comment -

      I have seen this XPDL example.
      Then I tried loading this package under the latest versions of a workflow engines, and I received an error - "There is invalid package ".
      I think this is the oldest problem of a transition from editor to engine.

      Show
      Sergey Shutov added a comment - I have seen this XPDL example. Then I tried loading this package under the latest versions of a workflow engines, and I received an error - "There is invalid package ". I think this is the oldest problem of a transition from editor to engine.
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Your patch is (partly) in OFBiz rev. 498425. I let this issue open for a while...

      Show
      Jacques Le Roux added a comment - Sergey, Your patch is (partly) in OFBiz rev. 498425. I let this issue open for a while...
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      I attached an example XPDL file from
      http://www.wfmc.org/standards/docs/xpdl_sample/sample%20workflow%20process.xpdl.
      I'm able to load it using Jawe XPDL editor :
      http://www.enhydra.org/workflow/jawe/index.html
      but Shark engine in OFBiz says
      "RepositoryManager -> upload of the file D:\WorkspaceNew\ofbiz\framework\shark\xpdl\example.xpdl failed because the package is not valid"
      Is that normal ?

      Thanks

      Show
      Jacques Le Roux added a comment - Sergey, I attached an example XPDL file from http://www.wfmc.org/standards/docs/xpdl_sample/sample%20workflow%20process.xpdl . I'm able to load it using Jawe XPDL editor : http://www.enhydra.org/workflow/jawe/index.html but Shark engine in OFBiz says "RepositoryManager -> upload of the file D:\WorkspaceNew\ofbiz\framework\shark\xpdl\example.xpdl failed because the package is not valid" Is that normal ? Thanks
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      I rewieved your patch, some comments.

      I changed all tabs to 4 spaces, that's our policy please see http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices and specially http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions
      Notably, please note that patches should be done from root and not framework. So your patch is to be applied from framework.

      I will not commit your changes to
      framework/base/config/jetty-containers.xml
      framework/base/config/ofbiz-containers.xml
      framework/base/config/test-containers.xml
      framework/build.xml
      framework/component-load.xml
      because they have been commented out for legal reasons (see OPTIONAL_LIBRARIES file please). But I agree that this might usefull for testing; specially if the pathes were changed from base/... to framework/base/...
      And sorry, because I ask you for shark versionned jar file but this is not really needed as this files will not be incorporated in the trunk (see OPTIONAL_LIBRARIES).

      Inshark/src/org/enhydra/shark/ThreadedToolAgentManager.java, are the lines
      +//import org.enhydra.jawe.xml.elements.Implementation;
      +//import org.enhydra.jawe.xml.elements.Tools;
      really needed ?

      The header you added is wrong,
      Index: shark/src/org/ofbiz/shark/SharkConstants.java
      ===================================================================
      — shark/src/org/ofbiz/shark/SharkConstants.java (revision 0)
      +++ shark/src/org/ofbiz/shark/SharkConstants.java (revision 0)
      @@ -0,0 +1,142 @@
      +/*
      + * Copyright 2001-2006 The Apache Software Foundation
      + *
      + * Licensed under the Apache License, Version 2.0 (the "License"); you may not
      + * use this file except in compliance with the License. You may obtain a copy of
      + * the License at
      + *
      + * http://www.apache.org/licenses/LICENSE-2.0
      + *
      + * Unless required by applicable law or agreed to in writing, software
      + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
      + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
      + * License for the specific language governing permissions and limitations
      + * under the License.
      + */
      it has recently changed. Please read my comment above https://issues.apache.org/jira/browse/OFBIZ-552#action_12466240

      Here is the patching result :
      patching file base/config/jetty-containers.xml
      patching file base/config/ofbiz-containers.xml
      patching file base/config/test-containers.xml
      patching file build.xml
      patching file component-load.xml
      patching file entity/fieldtype/fieldtypederby.xml
      patching file shark/build.xml
      patching file shark/entitydef/entitymodel.xml
      patching file shark/src/org/enhydra/shark/ThreadedToolAgentManager.java
      Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java
      Hunk #1 succeeded at 28 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/CreateProcessEventAudit.java
      Hunk #1 succeeded at 51 (offset 3 lines).
      Hunk #2 succeeded at 155 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/DataEventAudit.java
      Hunk #1 succeeded at 46 (offset 3 lines).
      Hunk #2 succeeded at 58 (offset 3 lines).
      Hunk #3 succeeded at 81 (offset 3 lines).
      Hunk #4 succeeded at 182 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/EntityAuditMgr.java
      Hunk #1 succeeded at 38 (offset 3 lines).
      Hunk #2 succeeded at 171 (offset 3 lines).
      Hunk #3 succeeded at 181 (offset 3 lines).
      Hunk #4 succeeded at 194 (offset 3 lines).
      Hunk #5 succeeded at 204 (offset 3 lines).
      Hunk #6 succeeded at 217 (offset 3 lines).
      Hunk #7 succeeded at 227 (offset 3 lines).
      Hunk #8 succeeded at 241 (offset 3 lines).
      Hunk #9 succeeded at 251 (offset 3 lines).
      Hunk #10 succeeded at 264 (offset 3 lines).
      Hunk #11 succeeded at 274 (offset 3 lines).
      Hunk #12 succeeded at 287 (offset 3 lines).
      Hunk #13 succeeded at 297 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/EventAudit.java
      Hunk #1 succeeded at 42 (offset 3 lines).
      Hunk #2 succeeded at 54 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/audit/StateEventAudit.java
      Hunk #1 succeeded at 39 (offset 3 lines).
      Hunk #2 succeeded at 51 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/auth/GenericAuthenticationMgr.java
      Hunk #1 succeeded at 23 (offset 3 lines).
      Hunk #2 succeeded at 45 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/auth/OfbizAuthenticationMgr.java
      Hunk #1 succeeded at 20 (offset 3 lines).
      Hunk #2 succeeded at 49 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/container/SharkContainer.java
      Hunk #1 succeeded at 19 (offset 3 lines).
      Hunk #2 succeeded at 70 (offset 3 lines).
      Hunk #3 succeeded at 131 (offset 3 lines).
      Hunk #4 succeeded at 158 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/expression/ActivityIteratorCondExprBldr.java
      Hunk #1 succeeded at 22 (offset 3 lines).
      Hunk #2 succeeded at 65 (offset 3 lines).
      Hunk #3 succeeded at 93 (offset 3 lines).
      Hunk #4 succeeded at 196 (offset 3 lines).
      Hunk #5 succeeded at 292 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/expression/AssignmentIteratorCondExprBldr.java
      Hunk #1 succeeded at 19 (offset 3 lines).
      Hunk #2 succeeded at 49 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/expression/ProcessIteratorCondExprBldr.java
      Hunk #1 succeeded at 20 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/expression/ProcessMgrIteratorCondExprBldr.java
      Hunk #1 succeeded at 19 (offset 3 lines).
      Hunk #2 succeeded at 51 (offset 3 lines).
      Hunk #3 succeeded at 92 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/expression/ResourceIteratorCondExprBldr.java
      Hunk #1 succeeded at 19 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/Activity.java
      Hunk #1 succeeded at 43 (offset 3 lines).
      Hunk #2 succeeded at 60 (offset 3 lines).
      Hunk #3 succeeded at 87 (offset 3 lines).
      Hunk #4 succeeded at 229 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/ActivityVariable.java
      Hunk #1 succeeded at 32 (offset 3 lines).
      Hunk #2 succeeded at 45 (offset 3 lines).
      Hunk #3 succeeded at 62 (offset 3 lines).
      Hunk #4 succeeded at 90 (offset 3 lines).
      Hunk #5 succeeded at 134 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/AndJoinEntry.java
      Hunk #1 succeeded at 30 (offset 3 lines).
      Hunk #2 succeeded at 42 (offset 3 lines).
      Hunk #3 succeeded at 59 (offset 3 lines).
      Hunk #4 succeeded at 86 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/Assignment.java
      Hunk #1 succeeded at 30 (offset 3 lines).
      Hunk #2 succeeded at 42 (offset 3 lines).
      Hunk #3 succeeded at 59 (offset 3 lines).
      Hunk #4 succeeded at 87 (offset 3 lines).
      Hunk #5 succeeded at 103 (offset 3 lines).
      Hunk #6 succeeded at 154 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/Deadline.java
      Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines).
      Hunk #2 succeeded at 44 (offset 3 lines).
      Hunk #3 succeeded at 61 (offset 3 lines).
      Hunk #4 succeeded at 88 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/EntityPersistentMgr.java
      Hunk #1 FAILED at 13.
      Hunk #2 succeeded at 203 (offset 3 lines).
      Hunk #3 succeeded at 214 (offset 3 lines).
      Hunk #4 succeeded at 224 (offset 3 lines).
      Hunk #5 succeeded at 286 (offset 3 lines).
      Hunk #6 succeeded at 296 (offset 3 lines).
      Hunk #7 succeeded at 305 (offset 3 lines).
      Hunk #8 succeeded at 357 (offset 3 lines).
      Hunk #9 succeeded at 369 (offset 3 lines).
      Hunk #10 succeeded at 387 (offset 3 lines).
      Hunk #11 succeeded at 407 (offset 3 lines).
      Hunk #12 succeeded at 420 (offset 3 lines).
      Hunk #13 succeeded at 451 (offset 3 lines).
      Hunk #14 succeeded at 474 (offset 3 lines).
      Hunk #15 succeeded at 494 (offset 3 lines).
      Hunk #16 succeeded at 537 (offset 3 lines).
      Hunk #17 succeeded at 551 (offset 3 lines).
      Hunk #18 succeeded at 623 (offset 3 lines).
      Hunk #19 succeeded at 647 (offset 3 lines).
      Hunk #20 succeeded at 664 (offset 3 lines).
      Hunk #21 succeeded at 676 (offset 3 lines).
      Hunk #22 succeeded at 686 (offset 3 lines).
      Hunk #23 succeeded at 701 (offset 3 lines).
      Hunk #24 succeeded at 723 (offset 3 lines).
      Hunk #25 succeeded at 741 (offset 3 lines).
      Hunk #26 succeeded at 768 (offset 3 lines).
      Hunk #27 succeeded at 786 (offset 3 lines).
      Hunk #28 succeeded at 801 (offset 3 lines).
      Hunk #29 succeeded at 824 (offset 3 lines).
      Hunk #30 succeeded at 858 (offset 3 lines).
      Hunk #31 succeeded at 876 (offset 3 lines).
      Hunk #32 succeeded at 899 (offset 3 lines).
      Hunk #33 succeeded at 944 (offset 3 lines).
      1 out of 33 hunks FAILED – saving rejects to file shark/src/org/ofbiz/shark/instance/EntityPersistentMgr.java.rej
      patching file shark/src/org/ofbiz/shark/instance/Process.java
      Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines).
      Hunk #2 succeeded at 47 (offset 3 lines).
      Hunk #3 succeeded at 66 (offset 3 lines).
      Hunk #4 succeeded at 85 (offset 3 lines).
      Hunk #5 succeeded at 96 (offset 3 lines).
      Hunk #6 succeeded at 233 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/ProcessMgr.java
      Hunk #1 succeeded at 33 (offset 3 lines).
      Hunk #2 succeeded at 41 (offset 3 lines).
      Hunk #3 succeeded at 58 (offset 3 lines).
      Hunk #4 succeeded at 85 (offset 3 lines).
      Hunk #5 succeeded at 135 (offset 3 lines).
      Hunk #6 succeeded at 147 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/ProcessVariable.java
      Hunk #1 succeeded at 31 (offset 3 lines).
      Hunk #2 succeeded at 43 (offset 3 lines).
      Hunk #3 succeeded at 60 (offset 3 lines).
      Hunk #4 succeeded at 88 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/instance/Resource.java
      Hunk #1 succeeded at 30 (offset 3 lines).
      Hunk #2 succeeded at 42 (offset 3 lines).
      Hunk #3 succeeded at 59 (offset 3 lines).
      Hunk #4 succeeded at 86 (offset 3 lines).
      Hunk #5 succeeded at 123 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/mapping/EntityApplicationMap.java
      Hunk #1 succeeded at 35 (offset 3 lines).
      Hunk #2 succeeded at 80 (offset 3 lines).
      Hunk #3 succeeded at 128 (offset 3 lines).
      Hunk #4 succeeded at 162 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/mapping/EntityApplicationMappingMgr.java
      Hunk #1 succeeded at 38 (offset 3 lines).
      Hunk #2 succeeded at 66 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java
      Hunk #1 succeeded at 31 (offset 3 lines).
      Hunk #2 succeeded at 43 (offset 3 lines).
      Hunk #3 succeeded at 58 (offset 3 lines).
      Hunk #4 succeeded at 85 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/mapping/EntityParticipantMappingMgr.java
      Hunk #1 succeeded at 39 (offset 3 lines).
      Hunk #2 succeeded at 55 (offset 3 lines).
      Hunk #3 succeeded at 64 (offset 3 lines).
      Hunk #4 succeeded at 97 (offset 3 lines).
      Hunk #5 succeeded at 118 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java
      Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines).
      Hunk #2 succeeded at 74 (offset 3 lines).
      Hunk #3 succeeded at 88 (offset 3 lines).
      Hunk #4 succeeded at 115 (offset 3 lines).
      Hunk #5 succeeded at 146 (offset 3 lines).
      Hunk #6 succeeded at 156 (offset 3 lines).
      Hunk #7 succeeded at 196 (offset 3 lines).
      Hunk #8 succeeded at 205 (offset 3 lines).
      Hunk #9 succeeded at 220 (offset 3 lines).
      Hunk #10 succeeded at 232 (offset 3 lines).
      Hunk #11 succeeded at 240 (offset 3 lines).
      Hunk #12 succeeded at 252 (offset 3 lines).
      Hunk #13 succeeded at 281 (offset 3 lines).
      Hunk #14 succeeded at 296 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/requester/AbstractRequester.java
      Hunk #1 succeeded at 122 (offset 3 lines).
      Hunk #2 succeeded at 211 (offset 3 lines).
      Hunk #3 succeeded at 224 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/requester/LoggingRequester.java
      Hunk #1 succeeded at 31 (offset 3 lines).
      Hunk #2 succeeded at 62 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/requester/ServiceRequester.java
      Hunk #1 FAILED at 1.
      Hunk #2 FAILED at 12.
      Hunk #3 succeeded at 33 (offset 3 lines).
      Hunk #4 succeeded at 63 (offset 3 lines).
      Hunk #5 succeeded at 75 (offset 3 lines).
      2 out of 5 hunks FAILED – saving rejects to file shark/src/org/ofbiz/shark/requester/ServiceRequester.java.rej
      patching file shark/src/org/ofbiz/shark/SharkConstants.java
      patching file shark/src/org/ofbiz/shark/tool/ServiceEngineAgent.java
      Hunk #1 succeeded at 34 (offset 3 lines).
      Hunk #2 succeeded at 49 (offset 3 lines).
      Hunk #3 succeeded at 77 (offset 3 lines).
      Hunk #4 succeeded at 93 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/user/GenericUserGroupMgr.java
      Hunk #1 succeeded at 52 (offset 3 lines).
      Hunk #2 succeeded at 61 (offset 3 lines).
      Hunk #3 succeeded at 72 (offset 3 lines).
      Hunk #4 succeeded at 81 (offset 3 lines).
      Hunk #5 succeeded at 92 (offset 3 lines).
      Hunk #6 succeeded at 101 (offset 3 lines).
      Hunk #7 succeeded at 128 (offset 3 lines).
      Hunk #8 succeeded at 161 (offset 3 lines).
      Hunk #9 succeeded at 203 (offset 3 lines).
      Hunk #10 succeeded at 215 (offset 3 lines).
      Hunk #11 succeeded at 239 (offset 3 lines).
      Hunk #12 succeeded at 254 (offset 3 lines).
      Hunk #13 succeeded at 299 (offset 3 lines).
      Hunk #14 succeeded at 319 (offset 3 lines).
      Hunk #15 succeeded at 354 (offset 3 lines).
      Hunk #16 succeeded at 367 (offset 3 lines).
      Hunk #17 succeeded at 402 (offset 3 lines).
      Hunk #18 succeeded at 414 (offset 3 lines).
      Hunk #19 succeeded at 426 (offset 3 lines).
      Hunk #20 succeeded at 438 (offset 3 lines).
      Hunk #21 succeeded at 446 (offset 3 lines).
      patching file shark/src/org/ofbiz/shark/user/PartyUserGroupMgr.java
      Hunk #1 succeeded at 26 (offset 3 lines).
      Hunk #2 succeeded at 45 (offset 3 lines).
      Hunk #3 succeeded at 70 (offset 3 lines).
      Hunk #4 succeeded at 108 (offset 3 lines).
      Hunk #5 succeeded at 158 (offset 3 lines).
      patching file shark/webapp/shark/process/processDetailList.ftl
      patching file shark/webapp/shark/process/processHistory.ftl
      patching file shark/webapp/shark/process/processList.ftl
      patching file shark/webapp/shark/WEB-INF/actions/process/processDetailList.bsh
      patching file shark/webapp/shark/WEB-INF/actions/process/processHistory.bsh
      patching file shark/webapp/shark/WEB-INF/actions/process/processList.bsh
      patching file shark/webapp/shark/WEB-INF/actions/repository/showRepository.bsh
      patching file shark/webapp/shark/WEB-INF/actions/tasklist/worklist.bsh
      A few hunks failed
      ServiceRequester.java is easy to change by hand, simply add
      import org.enhydra.shark.api.SharkTransaction;
      import org.enhydra.shark.api.client.wfbase.BaseException;
      import org.enhydra.shark.api.client.wfmodel.InvalidPerformer;
      import org.enhydra.shark.api.client.wfmodel.WfEventAudit;
      and neglict licence hunks issues (already OK)

      EntityPersistentMgr.java 1st hunk is easily resolved by merging.

      I post the original patch without tabs and the EntityPersistentMgr.java 1st hunk in patch which is to be resolved by merge.

      Compilation was ok. Congratulations, good work !

      Thanks

      Show
      Jacques Le Roux added a comment - Sergey, I rewieved your patch, some comments. I changed all tabs to 4 spaces, that's our policy please see http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices and specially http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions Notably, please note that patches should be done from root and not framework. So your patch is to be applied from framework. I will not commit your changes to framework/base/config/jetty-containers.xml framework/base/config/ofbiz-containers.xml framework/base/config/test-containers.xml framework/build.xml framework/component-load.xml because they have been commented out for legal reasons (see OPTIONAL_LIBRARIES file please). But I agree that this might usefull for testing; specially if the pathes were changed from base/... to framework/base/... And sorry, because I ask you for shark versionned jar file but this is not really needed as this files will not be incorporated in the trunk (see OPTIONAL_LIBRARIES). Inshark/src/org/enhydra/shark/ThreadedToolAgentManager.java, are the lines +//import org.enhydra.jawe.xml.elements.Implementation; +//import org.enhydra.jawe.xml.elements.Tools; really needed ? The header you added is wrong, Index: shark/src/org/ofbiz/shark/SharkConstants.java =================================================================== — shark/src/org/ofbiz/shark/SharkConstants.java (revision 0) +++ shark/src/org/ofbiz/shark/SharkConstants.java (revision 0) @@ -0,0 +1,142 @@ +/* + * Copyright 2001-2006 The Apache Software Foundation + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + */ it has recently changed. Please read my comment above https://issues.apache.org/jira/browse/OFBIZ-552#action_12466240 Here is the patching result : patching file base/config/jetty-containers.xml patching file base/config/ofbiz-containers.xml patching file base/config/test-containers.xml patching file build.xml patching file component-load.xml patching file entity/fieldtype/fieldtypederby.xml patching file shark/build.xml patching file shark/entitydef/entitymodel.xml patching file shark/src/org/enhydra/shark/ThreadedToolAgentManager.java Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/AssignmentEventAudit.java Hunk #1 succeeded at 28 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/CreateProcessEventAudit.java Hunk #1 succeeded at 51 (offset 3 lines). Hunk #2 succeeded at 155 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/DataEventAudit.java Hunk #1 succeeded at 46 (offset 3 lines). Hunk #2 succeeded at 58 (offset 3 lines). Hunk #3 succeeded at 81 (offset 3 lines). Hunk #4 succeeded at 182 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/EntityAuditMgr.java Hunk #1 succeeded at 38 (offset 3 lines). Hunk #2 succeeded at 171 (offset 3 lines). Hunk #3 succeeded at 181 (offset 3 lines). Hunk #4 succeeded at 194 (offset 3 lines). Hunk #5 succeeded at 204 (offset 3 lines). Hunk #6 succeeded at 217 (offset 3 lines). Hunk #7 succeeded at 227 (offset 3 lines). Hunk #8 succeeded at 241 (offset 3 lines). Hunk #9 succeeded at 251 (offset 3 lines). Hunk #10 succeeded at 264 (offset 3 lines). Hunk #11 succeeded at 274 (offset 3 lines). Hunk #12 succeeded at 287 (offset 3 lines). Hunk #13 succeeded at 297 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/EventAudit.java Hunk #1 succeeded at 42 (offset 3 lines). Hunk #2 succeeded at 54 (offset 3 lines). patching file shark/src/org/ofbiz/shark/audit/StateEventAudit.java Hunk #1 succeeded at 39 (offset 3 lines). Hunk #2 succeeded at 51 (offset 3 lines). patching file shark/src/org/ofbiz/shark/auth/GenericAuthenticationMgr.java Hunk #1 succeeded at 23 (offset 3 lines). Hunk #2 succeeded at 45 (offset 3 lines). patching file shark/src/org/ofbiz/shark/auth/OfbizAuthenticationMgr.java Hunk #1 succeeded at 20 (offset 3 lines). Hunk #2 succeeded at 49 (offset 3 lines). patching file shark/src/org/ofbiz/shark/container/SharkContainer.java Hunk #1 succeeded at 19 (offset 3 lines). Hunk #2 succeeded at 70 (offset 3 lines). Hunk #3 succeeded at 131 (offset 3 lines). Hunk #4 succeeded at 158 (offset 3 lines). patching file shark/src/org/ofbiz/shark/expression/ActivityIteratorCondExprBldr.java Hunk #1 succeeded at 22 (offset 3 lines). Hunk #2 succeeded at 65 (offset 3 lines). Hunk #3 succeeded at 93 (offset 3 lines). Hunk #4 succeeded at 196 (offset 3 lines). Hunk #5 succeeded at 292 (offset 3 lines). patching file shark/src/org/ofbiz/shark/expression/AssignmentIteratorCondExprBldr.java Hunk #1 succeeded at 19 (offset 3 lines). Hunk #2 succeeded at 49 (offset 3 lines). patching file shark/src/org/ofbiz/shark/expression/ProcessIteratorCondExprBldr.java Hunk #1 succeeded at 20 (offset 3 lines). patching file shark/src/org/ofbiz/shark/expression/ProcessMgrIteratorCondExprBldr.java Hunk #1 succeeded at 19 (offset 3 lines). Hunk #2 succeeded at 51 (offset 3 lines). Hunk #3 succeeded at 92 (offset 3 lines). patching file shark/src/org/ofbiz/shark/expression/ResourceIteratorCondExprBldr.java Hunk #1 succeeded at 19 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/Activity.java Hunk #1 succeeded at 43 (offset 3 lines). Hunk #2 succeeded at 60 (offset 3 lines). Hunk #3 succeeded at 87 (offset 3 lines). Hunk #4 succeeded at 229 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/ActivityVariable.java Hunk #1 succeeded at 32 (offset 3 lines). Hunk #2 succeeded at 45 (offset 3 lines). Hunk #3 succeeded at 62 (offset 3 lines). Hunk #4 succeeded at 90 (offset 3 lines). Hunk #5 succeeded at 134 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/AndJoinEntry.java Hunk #1 succeeded at 30 (offset 3 lines). Hunk #2 succeeded at 42 (offset 3 lines). Hunk #3 succeeded at 59 (offset 3 lines). Hunk #4 succeeded at 86 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/Assignment.java Hunk #1 succeeded at 30 (offset 3 lines). Hunk #2 succeeded at 42 (offset 3 lines). Hunk #3 succeeded at 59 (offset 3 lines). Hunk #4 succeeded at 87 (offset 3 lines). Hunk #5 succeeded at 103 (offset 3 lines). Hunk #6 succeeded at 154 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/Deadline.java Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines). Hunk #2 succeeded at 44 (offset 3 lines). Hunk #3 succeeded at 61 (offset 3 lines). Hunk #4 succeeded at 88 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/EntityPersistentMgr.java Hunk #1 FAILED at 13. Hunk #2 succeeded at 203 (offset 3 lines). Hunk #3 succeeded at 214 (offset 3 lines). Hunk #4 succeeded at 224 (offset 3 lines). Hunk #5 succeeded at 286 (offset 3 lines). Hunk #6 succeeded at 296 (offset 3 lines). Hunk #7 succeeded at 305 (offset 3 lines). Hunk #8 succeeded at 357 (offset 3 lines). Hunk #9 succeeded at 369 (offset 3 lines). Hunk #10 succeeded at 387 (offset 3 lines). Hunk #11 succeeded at 407 (offset 3 lines). Hunk #12 succeeded at 420 (offset 3 lines). Hunk #13 succeeded at 451 (offset 3 lines). Hunk #14 succeeded at 474 (offset 3 lines). Hunk #15 succeeded at 494 (offset 3 lines). Hunk #16 succeeded at 537 (offset 3 lines). Hunk #17 succeeded at 551 (offset 3 lines). Hunk #18 succeeded at 623 (offset 3 lines). Hunk #19 succeeded at 647 (offset 3 lines). Hunk #20 succeeded at 664 (offset 3 lines). Hunk #21 succeeded at 676 (offset 3 lines). Hunk #22 succeeded at 686 (offset 3 lines). Hunk #23 succeeded at 701 (offset 3 lines). Hunk #24 succeeded at 723 (offset 3 lines). Hunk #25 succeeded at 741 (offset 3 lines). Hunk #26 succeeded at 768 (offset 3 lines). Hunk #27 succeeded at 786 (offset 3 lines). Hunk #28 succeeded at 801 (offset 3 lines). Hunk #29 succeeded at 824 (offset 3 lines). Hunk #30 succeeded at 858 (offset 3 lines). Hunk #31 succeeded at 876 (offset 3 lines). Hunk #32 succeeded at 899 (offset 3 lines). Hunk #33 succeeded at 944 (offset 3 lines). 1 out of 33 hunks FAILED – saving rejects to file shark/src/org/ofbiz/shark/instance/EntityPersistentMgr.java.rej patching file shark/src/org/ofbiz/shark/instance/Process.java Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines). Hunk #2 succeeded at 47 (offset 3 lines). Hunk #3 succeeded at 66 (offset 3 lines). Hunk #4 succeeded at 85 (offset 3 lines). Hunk #5 succeeded at 96 (offset 3 lines). Hunk #6 succeeded at 233 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/ProcessMgr.java Hunk #1 succeeded at 33 (offset 3 lines). Hunk #2 succeeded at 41 (offset 3 lines). Hunk #3 succeeded at 58 (offset 3 lines). Hunk #4 succeeded at 85 (offset 3 lines). Hunk #5 succeeded at 135 (offset 3 lines). Hunk #6 succeeded at 147 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/ProcessVariable.java Hunk #1 succeeded at 31 (offset 3 lines). Hunk #2 succeeded at 43 (offset 3 lines). Hunk #3 succeeded at 60 (offset 3 lines). Hunk #4 succeeded at 88 (offset 3 lines). patching file shark/src/org/ofbiz/shark/instance/Resource.java Hunk #1 succeeded at 30 (offset 3 lines). Hunk #2 succeeded at 42 (offset 3 lines). Hunk #3 succeeded at 59 (offset 3 lines). Hunk #4 succeeded at 86 (offset 3 lines). Hunk #5 succeeded at 123 (offset 3 lines). patching file shark/src/org/ofbiz/shark/mapping/EntityApplicationMap.java Hunk #1 succeeded at 35 (offset 3 lines). Hunk #2 succeeded at 80 (offset 3 lines). Hunk #3 succeeded at 128 (offset 3 lines). Hunk #4 succeeded at 162 (offset 3 lines). patching file shark/src/org/ofbiz/shark/mapping/EntityApplicationMappingMgr.java Hunk #1 succeeded at 38 (offset 3 lines). Hunk #2 succeeded at 66 (offset 3 lines). patching file shark/src/org/ofbiz/shark/mapping/EntityParticipantMap.java Hunk #1 succeeded at 31 (offset 3 lines). Hunk #2 succeeded at 43 (offset 3 lines). Hunk #3 succeeded at 58 (offset 3 lines). Hunk #4 succeeded at 85 (offset 3 lines). patching file shark/src/org/ofbiz/shark/mapping/EntityParticipantMappingMgr.java Hunk #1 succeeded at 39 (offset 3 lines). Hunk #2 succeeded at 55 (offset 3 lines). Hunk #3 succeeded at 64 (offset 3 lines). Hunk #4 succeeded at 97 (offset 3 lines). Hunk #5 succeeded at 118 (offset 3 lines). patching file shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java Hunk #1 succeeded at 18 with fuzz 1 (offset 3 lines). Hunk #2 succeeded at 74 (offset 3 lines). Hunk #3 succeeded at 88 (offset 3 lines). Hunk #4 succeeded at 115 (offset 3 lines). Hunk #5 succeeded at 146 (offset 3 lines). Hunk #6 succeeded at 156 (offset 3 lines). Hunk #7 succeeded at 196 (offset 3 lines). Hunk #8 succeeded at 205 (offset 3 lines). Hunk #9 succeeded at 220 (offset 3 lines). Hunk #10 succeeded at 232 (offset 3 lines). Hunk #11 succeeded at 240 (offset 3 lines). Hunk #12 succeeded at 252 (offset 3 lines). Hunk #13 succeeded at 281 (offset 3 lines). Hunk #14 succeeded at 296 (offset 3 lines). patching file shark/src/org/ofbiz/shark/requester/AbstractRequester.java Hunk #1 succeeded at 122 (offset 3 lines). Hunk #2 succeeded at 211 (offset 3 lines). Hunk #3 succeeded at 224 (offset 3 lines). patching file shark/src/org/ofbiz/shark/requester/LoggingRequester.java Hunk #1 succeeded at 31 (offset 3 lines). Hunk #2 succeeded at 62 (offset 3 lines). patching file shark/src/org/ofbiz/shark/requester/ServiceRequester.java Hunk #1 FAILED at 1. Hunk #2 FAILED at 12. Hunk #3 succeeded at 33 (offset 3 lines). Hunk #4 succeeded at 63 (offset 3 lines). Hunk #5 succeeded at 75 (offset 3 lines). 2 out of 5 hunks FAILED – saving rejects to file shark/src/org/ofbiz/shark/requester/ServiceRequester.java.rej patching file shark/src/org/ofbiz/shark/SharkConstants.java patching file shark/src/org/ofbiz/shark/tool/ServiceEngineAgent.java Hunk #1 succeeded at 34 (offset 3 lines). Hunk #2 succeeded at 49 (offset 3 lines). Hunk #3 succeeded at 77 (offset 3 lines). Hunk #4 succeeded at 93 (offset 3 lines). patching file shark/src/org/ofbiz/shark/user/GenericUserGroupMgr.java Hunk #1 succeeded at 52 (offset 3 lines). Hunk #2 succeeded at 61 (offset 3 lines). Hunk #3 succeeded at 72 (offset 3 lines). Hunk #4 succeeded at 81 (offset 3 lines). Hunk #5 succeeded at 92 (offset 3 lines). Hunk #6 succeeded at 101 (offset 3 lines). Hunk #7 succeeded at 128 (offset 3 lines). Hunk #8 succeeded at 161 (offset 3 lines). Hunk #9 succeeded at 203 (offset 3 lines). Hunk #10 succeeded at 215 (offset 3 lines). Hunk #11 succeeded at 239 (offset 3 lines). Hunk #12 succeeded at 254 (offset 3 lines). Hunk #13 succeeded at 299 (offset 3 lines). Hunk #14 succeeded at 319 (offset 3 lines). Hunk #15 succeeded at 354 (offset 3 lines). Hunk #16 succeeded at 367 (offset 3 lines). Hunk #17 succeeded at 402 (offset 3 lines). Hunk #18 succeeded at 414 (offset 3 lines). Hunk #19 succeeded at 426 (offset 3 lines). Hunk #20 succeeded at 438 (offset 3 lines). Hunk #21 succeeded at 446 (offset 3 lines). patching file shark/src/org/ofbiz/shark/user/PartyUserGroupMgr.java Hunk #1 succeeded at 26 (offset 3 lines). Hunk #2 succeeded at 45 (offset 3 lines). Hunk #3 succeeded at 70 (offset 3 lines). Hunk #4 succeeded at 108 (offset 3 lines). Hunk #5 succeeded at 158 (offset 3 lines). patching file shark/webapp/shark/process/processDetailList.ftl patching file shark/webapp/shark/process/processHistory.ftl patching file shark/webapp/shark/process/processList.ftl patching file shark/webapp/shark/WEB-INF/actions/process/processDetailList.bsh patching file shark/webapp/shark/WEB-INF/actions/process/processHistory.bsh patching file shark/webapp/shark/WEB-INF/actions/process/processList.bsh patching file shark/webapp/shark/WEB-INF/actions/repository/showRepository.bsh patching file shark/webapp/shark/WEB-INF/actions/tasklist/worklist.bsh A few hunks failed ServiceRequester.java is easy to change by hand, simply add import org.enhydra.shark.api.SharkTransaction; import org.enhydra.shark.api.client.wfbase.BaseException; import org.enhydra.shark.api.client.wfmodel.InvalidPerformer; import org.enhydra.shark.api.client.wfmodel.WfEventAudit; and neglict licence hunks issues (already OK) EntityPersistentMgr.java 1st hunk is easily resolved by merging. I post the original patch without tabs and the EntityPersistentMgr.java 1st hunk in patch which is to be resolved by merge. Compilation was ok. Congratulations, good work ! Thanks
      Hide
      Sergey Shutov added a comment -

      Thanks

      I have found my bad comments in shark.properties a file. I have removed it,
      and uploaded a new version file to JIRA.

      Best Regards

      Show
      Sergey Shutov added a comment - Thanks I have found my bad comments in shark.properties a file. I have removed it, and uploaded a new version file to JIRA. Best Regards
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Yes at first glance it looks good. I will begin to review it more seriously and will let you know.

      Thanks

      Show
      Jacques Le Roux added a comment - Sergey, Yes at first glance it looks good. I will begin to review it more seriously and will let you know. Thanks
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Sorry, I was wrongly writting your 1st name until now :/

      That's great the zip file looks good (I will deal with js.jar). Now please, read my messages (I repeat please read my msg).
      To allow me to commit your work legally you need to :
      1. Put ASL2 headers in all your own files : please read carefully http://www.apache.org/legal/src-headers.html or at least put
      this as an header of all your files

      Licensed to the Apache Software Foundation (ASF) under one
      or more contributor license agreements. See the NOTICE file
      distributed with this work for additional information
      regarding copyright ownership. The ASF licenses this file
      to you under the Apache License, Version 2.0 (the
      "License"); you may not use this file except in compliance
      with the License. You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

      Unless required by applicable law or agreed to in writing,
      software distributed under the License is distributed on an
      "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
      KIND, either express or implied. See the License for the
      specific language governing permissions and limitations
      under the License.

      2. Check the ASF Granted License when you attach a file to a Jira issue

      Thanks for all your work

      Show
      Jacques Le Roux added a comment - Sergey, Sorry, I was wrongly writting your 1st name until now :/ That's great the zip file looks good (I will deal with js.jar). Now please, read my messages (I repeat please read my msg). To allow me to commit your work legally you need to : 1. Put ASL2 headers in all your own files : please read carefully http://www.apache.org/legal/src-headers.html or at least put this as an header of all your files Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. 2. Check the ASF Granted License when you attach a file to a Jira issue Thanks for all your work
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Yes of course, please may you attach the jar file with version in its name. We now use versionned jar files, you may find examples of how jars are named in OFBiz.

      Thanks

      Show
      Jacques Le Roux added a comment - Sergey, Yes of course, please may you attach the jar file with version in its name. We now use versionned jar files, you may find examples of how jars are named in OFBiz. Thanks
      Hide
      Sergey Shutov added a comment -

      491-862 - this is a Shark libraries of 1.2-1 version. I should not upload them?

      Show
      Sergey Shutov added a comment - 491-862 - this is a Shark libraries of 1.2-1 version. I should not upload them?
      Hide
      Jacques Le Roux added a comment -

      Serguey,

      Now that I can look at the patch properties I see that you have not cheked the "grant asl" box. Please do it, this is required to allow commit of your patch in OFBiz (though the most important is that yuou put the new ASL2 header in your files)

      Thanks

      Show
      Jacques Le Roux added a comment - Serguey, Now that I can look at the patch properties I see that you have not cheked the "grant asl" box. Please do it, this is required to allow commit of your patch in OFBiz (though the most important is that yuou put the new ASL2 header in your files) Thanks
      Hide
      Jacques Le Roux added a comment -

      OK no more problem in Jira (after about 10 hours hanged ;o)

      Show
      Jacques Le Roux added a comment - OK no more problem in Jira (after about 10 hours hanged ;o)
      Hide
      Jacques Le Roux added a comment -

      Serguey, John,

      I was considering to apply this new patch. My 1st review shows me that they are 1550 tabs (minus those generated by differ tool) in this patch. Please Serguey consider reading the reference I gave to you above, thanks. This is not a problem for this patch, I will take care of that. But please in future think about it. Commiter could be a hard job sometimes...

      Here are some other comments

      Not sure lines 491-862 are relevant ?

      There are still some copyright notices, notably in
      ThreadedToolAgentManager.java
      SharkContainer.java
      but that's not a big problem. I can take care of that (btw they are not Serguey's)

      There are 4 "//System.err.println" but this is perhaps needed for future debugging ? In this case it seems better to use std OFBiz feature (Debug.logInfo, etc.)

      There are 155 "System.out.println", this should be replaced by Debug.logInfo or .Verbose, or else as needed

      There are 45 "Debug.log(". Note that this will always prompt in log and perhaps should be replaced by Debug.logInfo or .Verbose, or else as needed

      ASL header is missing in new file SharkConstants.java. Beware that the header has changed : http://www.apache.org/legal/src-headers.html

      A part from this minor problems the patch looks good.

      They are 92 files changed in this 7200 lines patch so now that John seems interested to test it I will wait his comments before doing more work on this.

      BTW there is a bug in Jira (I will post about it in Apache infra) that prevents to get rid of the old patch.

      Show
      Jacques Le Roux added a comment - Serguey, John, I was considering to apply this new patch. My 1st review shows me that they are 1550 tabs (minus those generated by differ tool) in this patch. Please Serguey consider reading the reference I gave to you above, thanks. This is not a problem for this patch, I will take care of that. But please in future think about it. Commiter could be a hard job sometimes... Here are some other comments Not sure lines 491-862 are relevant ? There are still some copyright notices, notably in ThreadedToolAgentManager.java SharkContainer.java but that's not a big problem. I can take care of that (btw they are not Serguey's) There are 4 "//System.err.println" but this is perhaps needed for future debugging ? In this case it seems better to use std OFBiz feature (Debug.logInfo, etc.) There are 155 "System.out.println", this should be replaced by Debug.logInfo or .Verbose, or else as needed There are 45 "Debug.log(". Note that this will always prompt in log and perhaps should be replaced by Debug.logInfo or .Verbose, or else as needed ASL header is missing in new file SharkConstants.java. Beware that the header has changed : http://www.apache.org/legal/src-headers.html A part from this minor problems the patch looks good. They are 92 files changed in this 7200 lines patch so now that John seems interested to test it I will wait his comments before doing more work on this. BTW there is a bug in Jira (I will post about it in Apache infra) that prevents to get rid of the old patch.
      Hide
      Sergey Shutov added a comment -

      Hello,

      This module is ready to be used.

      We use a component of a Shark in OfBiz for company business automation with
      the purpose of reception of certificate ISO9000.

      PS
      If you have any question or comments about code, you can send me e-mail.

      Show
      Sergey Shutov added a comment - Hello, This module is ready to be used. We use a component of a Shark in OfBiz for company business automation with the purpose of reception of certificate ISO9000. PS If you have any question or comments about code, you can send me e-mail.
      Hide
      John Martin added a comment -

      Sergey,

      With your changes, how close would you say Shark is to being usable in ofBiz? We are considering using it if it is ready.

      Thanks!

      Show
      John Martin added a comment - Sergey, With your changes, how close would you say Shark is to being usable in ofBiz? We are considering using it if it is ready. Thanks!
      Hide
      Sergey Shutov added a comment -

      I have attached a new diff file.
      Without information about me.

      Show
      Sergey Shutov added a comment - I have attached a new diff file. Without information about me.
      Hide
      Jacques Le Roux added a comment -

      I forgot to say that when you send a replacing patch please use the same name. The reason is explained in a comment at bottom of http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

      Show
      Jacques Le Roux added a comment - I forgot to say that when you send a replacing patch please use the same name. The reason is explained in a comment at bottom of http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
      Hide
      Jacques Le Roux added a comment -

      Sergey,

      Wow, this is an huge patch !

      Please consider this 1st comments as only admin/formattng stuffes and not technical ones

      . Please don' t use tabs in your files and patches. BTW you may have a look at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

      . If you want this patch being commited to OFBiz you will have to check the ASF grant when attaching your patch. In the same spirit please don't let copyright info in your files/patches, like
      +@Modified by Sergey Shutov. Tecomgroup company.
      +@E-mail : sshutov@tecomgroup.ru

      . I think that comments with your name like <!-- Modified field "eventAuditId" with type "id-ne" by Sergey Shutov --> are ok BTW. But they are not necessary because SVN take care of that (history). So for us (commiters) they only add more lines to go through.... So please delete them.

      Thanks for your work !

      Show
      Jacques Le Roux added a comment - Sergey, Wow, this is an huge patch ! Please consider this 1st comments as only admin/formattng stuffes and not technical ones . Please don' t use tabs in your files and patches. BTW you may have a look at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices . If you want this patch being commited to OFBiz you will have to check the ASF grant when attaching your patch. In the same spirit please don't let copyright info in your files/patches, like +@Modified by Sergey Shutov. Tecomgroup company. +@E-mail : sshutov@tecomgroup.ru . I think that comments with your name like <!-- Modified field "eventAuditId" with type "id-ne" by Sergey Shutov --> are ok BTW. But they are not necessary because SVN take care of that (history). So for us (commiters) they only add more lines to go through.... So please delete them. Thanks for your work !

        People

        • Assignee:
          Jacques Le Roux
          Reporter:
          Sergey Shutov
        • Votes:
          1 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development