OFBiz
  1. OFBiz
  2. OFBIZ-517

createPartyPostalAddress should set contactMechTypeId

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: party
    • Labels:
      None

      Description

      In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.

      Same thing with createPartyTelecom

        Activity

        Gavin made changes -
        Workflow jira [ 12391297 ] OFbiz Workflow [ 12504686 ]
        Jacques Le Roux made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s SVN trunk [ 12311928 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Le Roux added a comment -

        I applied the patch but please next time Al don't forget to make the patch from root. It's uneasy to apply patches without relative pathes from root.
        ie
        good : applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml
        not good : PartyContactMechServices.xml

        BTW like explained Jacopo as a member of PMC and commiter you should be able to commit yourself.

        Completed: At revision: 484977

        Thanks ;o)

        Show
        Jacques Le Roux added a comment - I applied the patch but please next time Al don't forget to make the patch from root. It's uneasy to apply patches without relative pathes from root. ie good : applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml not good : PartyContactMechServices.xml BTW like explained Jacopo as a member of PMC and commiter you should be able to commit yourself. Completed: At revision: 484977 Thanks ;o)
        Jacques Le Roux made changes -
        Attachment PartyContactMechServices.patch [ 12346288 ]
        Hide
        Jacopo Cappellato added a comment -

        Al,

        I think you are right and your second patch should be committed: you should have the commit rights of doing it and close this issue, but if you have any issue with it I can do it for you.

        Show
        Jacopo Cappellato added a comment - Al, I think you are right and your second patch should be committed: you should have the commit rights of doing it and close this issue, but if you have any issue with it I can do it for you.
        Hide
        Al Byers added a comment -

        The previous fix for this problem was incorrect.
        It looks like these lines needed to be swapped in PartyContactMechServices.createPartyPostalAddrss:
        <set-service-fields service-name="createPartyContactMech" map-name="parameters" to-map-name="createPartyContactMechMap"/>
        <set field="createPartyContactMechMap.contactMechId" from-field="newPartyContactMech.contactMechId"/>
        (that is correct as is)

        Show
        Al Byers added a comment - The previous fix for this problem was incorrect. It looks like these lines needed to be swapped in PartyContactMechServices.createPartyPostalAddrss: <set-service-fields service-name="createPartyContactMech" map-name="parameters" to-map-name="createPartyContactMechMap"/> <set field="createPartyContactMechMap.contactMechId" from-field="newPartyContactMech.contactMechId"/> (that is correct as is)
        Al Byers made changes -
        Attachment PartyContactMechServices.patch [ 12346451 ]
        Hide
        Al Byers added a comment -

        the previous upload would not fix the problem correctly.
        this patch moves the order of setting the contactMechId in createPartyPostalAddress to after the auto setting of parameters.

        Show
        Al Byers added a comment - the previous upload would not fix the problem correctly. this patch moves the order of setting the contactMechId in createPartyPostalAddress to after the auto setting of parameters.
        Al Byers made changes -
        Field Original Value New Value
        Attachment PartyContactMechServices.patch [ 12346288 ]
        Al Byers created issue -

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Al Byers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development