[OFBIZ-5098] javascript error in hidden form

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release 10.04, Trunk
• Fix Version/s: Release Branch 10.04, Release Branch 11.04, Release Branch 12.04, Trunk
• Component/s: framework
• Assignee: Jacques Le Roux
• Reporter: Naofumi Fukue
• Created: 11/Dec/12 13:54
• Updated: 15/Dec/12 11:12
• Resolved: 15/Dec/12 11:12

Description

HtmlMenuRenderer generates like bellow form tags. It generates double target="_BLANK" , then cause javascript error.

<li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>

document.InvoiceSubTabBar_pdf_LF_8 is undefined @ javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()

Index: framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
===================================================================
— framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java (revision 1419381)
+++ framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java (working copy)
@@ -455,10 +455,12 @@
writer.append(name);
writer.append("\"");
}

• if (UtilValidate.isNotEmpty(targetWindow)) {
• writer.append(" target=\"");
• writer.append(targetWindow);
• writer.append("\"");
  + if (!"hidden-form".equals(linkType))
  Unknown macro: {+ if (UtilValidate.isNotEmpty(targetWindow)) { + writer.append(" target=\""); + writer.append(targetWindow); + writer.append("\""); + } }

writer.append(" href=\"");