Description
This code in GenericEntity.java:
Debug.logWarning("The field name (or key) [" + name + "] is not valid for entity [" + this.getEntityName() + "], printing IllegalArgumentException instead of throwing it because Map interface specification does not allow throwing that exception.", module);
is really annoying and IMHO it is wrong.
First, it does not print an exception, it only prints that string with no stacktrace (I think that was changed at some point).
Second, IllegalArgument is a RuntimeException so the interface doesn't really need to allow it to be thrown, right?
Personally, I think the warning is not even justified. We sometimes don't know exactly what kind of entity we're dealing with and just check if it has that field or not. With this code, to prevent excessive log clutter, we have to wrap each call with a "if (it.containsKey())". A java map will just return null silently as well, and this behavior is documented in the Map interface. If anyone is really worried about accessing fields wrong (your tests should catch that error), there could be an extra method "getOrThrow" or something, but get should just return the value or null.
Otherwise, at least throw the exception. Log warnings are usually found while monitoring production logs, developers will find this much earlier otherwise.
Attachments
Attachments
Issue Links
- is related to
-
OFBIZ-5925 Pack order flow is broken
-
- Closed
-
-
-
- Closed
-