OFBiz
  1. OFBiz
  2. OFBIZ-4866

Split Into Multiple Shipment Button is not working

    Details

      Description

      Split Into Multiple Shipment Button is not working on quick checkout page

      https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout

      1. OFBIZ-4866.patch
        23 kB
        Ankit Jain
      2. Updated_OFBIZ-4866.patch
        25 kB
        Ankit Jain
      3. Updated_OFBIZ-4866.patch
        23 kB
        Ankit Jain

        Activity

        Hide
        Ankit Jain added a comment -

        I have checked code and found that either its not implemented or code is removed.

        I am not sure its a bug or an improvement, I took reference from front-end Split Ship functionality and implemented it for backend quick checkout.

        Attaching patch for it.

        Show
        Ankit Jain added a comment - I have checked code and found that either its not implemented or code is removed. I am not sure its a bug or an improvement, I took reference from front-end Split Ship functionality and implemented it for backend quick checkout. Attaching patch for it.
        Hide
        Pierre Smits added a comment -

        Hi ankit Jain,

        Can this also be applied to already released versions? If so, would you please be so kind to adjust the affected and fix versions?

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - Hi ankit Jain, Can this also be applied to already released versions? If so, would you please be so kind to adjust the affected and fix versions? Regards, Pierre
        Hide
        Ankit Jain added a comment -

        Updated patch.

        Show
        Ankit Jain added a comment - Updated patch.
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        Could you please give more information where to find this "not working" thing on UI?

        Also can't we reuse code from order manager in ecommerce at the end?

        Show
        Jacques Le Roux added a comment - Hi Ankit, Could you please give more information where to find this "not working" thing on UI? Also can't we reuse code from order manager in ecommerce at the end?
        Hide
        Ankit Jain added a comment -

        Jacques,

        In ecommerce this functionality is working, I did for ordermgr.

        When you place and order from backend(Ordermgr) and chose Quick Finalize Order it redirect you to quickcheckout page (https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout) here on the left side there is a button "Split into multiple Shipment". When you click on this button it will show

        org.ofbiz.webapp.control.RequestHandlerException: Unknown request [splitship]; this request does not exist or cannot be called directly.

        I took the reference and also reused the code of ecommerce for this Split Shipment.

        Show
        Ankit Jain added a comment - Jacques, In ecommerce this functionality is working, I did for ordermgr. When you place and order from backend(Ordermgr) and chose Quick Finalize Order it redirect you to quickcheckout page ( https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout ) here on the left side there is a button "Split into multiple Shipment". When you click on this button it will show org.ofbiz.webapp.control.RequestHandlerException: Unknown request [splitship] ; this request does not exist or cannot be called directly. I took the reference and also reused the code of ecommerce for this Split Shipment.
        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        It was late and stupidely I only added one item, so the button did not show

        About my other point, I think we should really avoid do "duplicate" ecommerce code in order manager. Could we not rather refactor the code and include only one version in order manager then used also from ecommerce? Because dependency from order manager is correct but other way is bad. I know you did not "reuse" the code but duplicated it rather.

        To summarize:

        • Duplicate/adapt ecommerce in order manager => bad
        • Make a dependency from order manager to ecommerce => bad
        • Make a dependency from ecommerce to order manager => best practise

        I might have missed something (just browsed the patch), then please explain.

        Show
        Jacques Le Roux added a comment - Thanks Ankit, It was late and stupidely I only added one item, so the button did not show About my other point, I think we should really avoid do "duplicate" ecommerce code in order manager. Could we not rather refactor the code and include only one version in order manager then used also from ecommerce? Because dependency from order manager is correct but other way is bad. I know you did not "reuse" the code but duplicated it rather. To summarize: Duplicate/adapt ecommerce in order manager => bad Make a dependency from order manager to ecommerce => bad Make a dependency from ecommerce to order manager => best practise I might have missed something (just browsed the patch), then please explain.
        Hide
        Ankit Jain added a comment -

        Jacques,

        The ordermgr code is not dependend on ecommerce code and also not a duplicate, I have modified the code and used here in ordermgr.

        Now we can reuse this code in ecommerce.

        Attaching a updated patch.

        Show
        Ankit Jain added a comment - Jacques, The ordermgr code is not dependend on ecommerce code and also not a duplicate, I have modified the code and used here in ordermgr. Now we can reuse this code in ecommerce. Attaching a updated patch.
        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        Your patch is in
        trunk r1340415
        R12.04 r1340417
        R11.04 r1340418
        R10.04 r1340419

        Show
        Jacques Le Roux added a comment - Thanks Ankit, Your patch is in trunk r1340415 R12.04 r1340417 R11.04 r1340418 R10.04 r1340419
        Hide
        Ankit Jain added a comment -

        Thanks Jacques

        Show
        Ankit Jain added a comment - Thanks Jacques

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Ankit Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development