OFBiz
  1. OFBiz
  2. OFBIZ-4864

Mechanism to publish information about connection pools

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      Please review the attached patch that I would like to commit to trunk:

      • enabled by default the DebugManagedDataSource wrapper around ManagedDataSource
      • enhanced the DebugManagedDataSource wrapper to:
        • print log messages only at verbose level (instead of always)
        • if possible print additional information about the connection status
        • added new method that returns information about the connection pool settings/status
      • added new static method to DBCPConnectionFactory to return information about the pools
      • new screen in the webtools where information about each pool/helper is shown (see screenshot)

      What do you think? The code is safe and it will not have any impact on performance (unless you enable verbose logging on DebugManagedDataSource). The information provided by the screen can be very useful to analyze the status of the pools.

      1. pools-status.png
        87 kB
        Jacopo Cappellato
      2. pools-status.patch
        13 kB
        Jacopo Cappellato

        Activity

        Jacopo Cappellato created issue -
        Jacopo Cappellato made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jacopo Cappellato made changes -
        Attachment pools-status.patch [ 12525986 ]
        Jacopo Cappellato made changes -
        Attachment pools-status.png [ 12525987 ]
        Hide
        Jacques Le Roux added a comment -

        I like the feature, did not review, nor test, yet

        Show
        Jacques Le Roux added a comment - I like the feature, did not review, nor test, yet
        Jacopo Cappellato committed 1338230 (8 files)
        Reviews: none

        OFBIZ-4864
        * enabled by default the DebugManagedDataSource wrapper around ManagedDataSource
        * enhanced the DebugManagedDataSource wrapper to:
        ** print log messages only at verbose level (instead of always as it was before)
        ** if possible print additional information about the connection status
        ** added new method that returns information about the connection pool settings/status
        * added new static method to DBCPConnectionFactory to return information about the pools
        * new screen in the webtools where information about each pool/helper is shown
        The information provided by the screen can be very useful to analyze the status of the connection pools.

        Jacopo Cappellato made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacopo Cappellato added a comment -

        Committed to trunk in rev. 1338230

        Show
        Jacopo Cappellato added a comment - Committed to trunk in rev. 1338230
        Jacopo Cappellato made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jacopo Cappellato
            Reporter:
            Jacopo Cappellato
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development